Re: [PATCH v3 14/16] phy: Add notify_speed callback

2018-01-01 Thread Manu Gautam
Hi, On 12/29/2017 11:58 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 29 December 2017 09:54 AM, Manu Gautam wrote: >> Hi, [snip] > > suggest using switch in such case.. and not all PHY drivers do specific > configurations for specific speeds. >> This looks clumsy. >> Where as if bits to

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-28 Thread Kishon Vijay Abraham I
Hi, On Friday 29 December 2017 09:54 AM, Manu Gautam wrote: > Hi, > > > On 12/28/2017 4:34 PM, Kishon Vijay Abraham I wrote: >> Hi, >> > [snip] >> I'd prefer adding modes in enum phy_mode according to speed and using phy_set_mode. >>> yeah, that also seems good idea. How about somethi

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-28 Thread Manu Gautam
Hi, On 12/28/2017 4:34 PM, Kishon Vijay Abraham I wrote: > Hi, > [snip] > >>> I'd prefer adding modes in enum phy_mode according to speed and using >>> phy_set_mode. >> yeah, that also seems good idea. How about something like this: >> >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-28 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 December 2017 02:11 PM, Manu Gautam wrote: > Hi > > > On 12/20/2017 12:47 PM, Kishon Vijay Abraham I wrote: >> Hi, >> > [snip] Why not use a notification mechanism instead of adding new APIs in phy-core. This will only bloat phy-core with APIs for a particular

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-20 Thread Manu Gautam
Hi On 12/20/2017 12:47 PM, Kishon Vijay Abraham I wrote: > Hi, > [snip] >>> Why not use a notification mechanism instead of adding new APIs in phy-core. >>> This will only bloat phy-core with APIs for a particular platform. >> Do you mean notifier_chains ? >> When we have multiple instances of US

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 December 2017 11:59 AM, Manu Gautam wrote: > Hi, > > > On 12/20/2017 11:19 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: >>> Hi, >>> >>> >>> On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: Hi, On Tu

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Manu Gautam
Hi, On 12/20/2017 11:19 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: >> Hi, >> >> >> On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: QCOM USB PHYs can monitor

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Kishon Vijay Abraham I
Hi, On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: > Hi, > > > On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: >>> QCOM USB PHYs can monitor resume/remote-wakeup event in >>> suspended state. However PHY driver

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-12 Thread Manu Gautam
Hi, On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: >> QCOM USB PHYs can monitor resume/remote-wakeup event in >> suspended state. However PHY driver must know current >> operational speed of PHY in order to set correct polar

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-12 Thread Kishon Vijay Abraham I
Hi, On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: > QCOM USB PHYs can monitor resume/remote-wakeup event in > suspended state. However PHY driver must know current > operational speed of PHY in order to set correct polarity of > wakeup events for detection. E.g. QUSB2 PHY monitors DP/DM