Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-17 Thread Vivek Gautam
Hi Tomasz, On Fri, Feb 14, 2014 at 9:17 PM, Tomasz Figa wrote: mistakenly didn't do "Reply All", so sending it again. > Hi Vivek, > > > On 14.02.2014 14:53, Vivek Gautam wrote: Changes from v2: 1) Added support for multiple PHYs (UTMI+ and PIPE3) and related changes in

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-14 Thread Tomasz Figa
Hi Vivek, On 14.02.2014 14:53, Vivek Gautam wrote: Changes from v2: 1) Added support for multiple PHYs (UTMI+ and PIPE3) and related changes in the driver structuring. I'm a bit skeptical about this separation. Can the PHY operate with just the UTMI+ or PIPE3 part enabled alone without t

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-14 Thread Vivek Gautam
Hi Tomasz, On Thu, Feb 6, 2014 at 7:37 PM, Tomasz Figa wrote: > Hi Vivek, > > This patch is just adding the PHY driver. I would also like to look at some > users of it, to see how this works when put together. The DWC3's changes had been posted by Kishon sometime back, which will enable DWC3 to

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-10 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 February 2014 07:37 PM, Tomasz Figa wrote: > Hi Vivek, > > This patch is just adding the PHY driver. I would also like to look at some > users of it, to see how this works when put together. > > For now, please see my comments inline. > > On 20.01.2014 14:42, Vivek Gautam wro

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-06 Thread Tomasz Figa
Hi Vivek, This patch is just adding the PHY driver. I would also like to look at some users of it, to see how this works when put together. For now, please see my comments inline. On 20.01.2014 14:42, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-29 Thread Vivek Gautam
Hi, On Thu, Jan 30, 2014 at 11:48 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 30 January 2014 09:49 AM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >> >> Thanks for review. Please find my answers inline below.

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-29 Thread Kishon Vijay Abraham I
Hi, On Thursday 30 January 2014 09:49 AM, Vivek Gautam wrote: > Hi Kishon, > > > On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I wrote: >> Hi, > > Thanks for review. Please find my answers inline below. > >> >> On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote: >>> Add a new driv

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-29 Thread Vivek Gautam
Hi Kishon, On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I wrote: > Hi, Thanks for review. Please find my answers inline below. > > On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the gene

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-27 Thread Kishon Vijay Abraham I
Hi, On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb3 driver

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-20 Thread Vivek Gautam
On Mon, Jan 20, 2014 at 7:12 PM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb3 driver and rel