Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
On Thu, Feb 26, 2015 at 02:38:07PM -0600, Bin Liu wrote: > On Thu, Feb 26, 2015 at 2:31 PM, Felipe Balbi wrote: > > On Thu, Feb 26, 2015 at 02:25:20PM -0600, Bin Liu wrote: > >> On Thu, Feb 26, 2015 at 2:19 PM, Felipe Balbi wrote: > >> > Hi again, > >> > > >> > On Thu, Feb 26, 2015 at 02:15:40PM

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Bin Liu
On Thu, Feb 26, 2015 at 2:31 PM, Felipe Balbi wrote: > On Thu, Feb 26, 2015 at 02:25:20PM -0600, Bin Liu wrote: >> On Thu, Feb 26, 2015 at 2:19 PM, Felipe Balbi wrote: >> > Hi again, >> > >> > On Thu, Feb 26, 2015 at 02:15:40PM -0600, Felipe Balbi wrote: >> >> > > >> >> > On Thu, Feb 26, 2015 at

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
On Thu, Feb 26, 2015 at 02:25:20PM -0600, Bin Liu wrote: > On Thu, Feb 26, 2015 at 2:19 PM, Felipe Balbi wrote: > > Hi again, > > > > On Thu, Feb 26, 2015 at 02:15:40PM -0600, Felipe Balbi wrote: > >> > > >> >> > On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: > >> > > >> >> >> FSDEV

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Bin Liu
On Thu, Feb 26, 2015 at 2:19 PM, Felipe Balbi wrote: > Hi again, > > On Thu, Feb 26, 2015 at 02:15:40PM -0600, Felipe Balbi wrote: >> > > >> >> > On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: >> > > >> >> >> FSDEV is set for both HIGH and FULL speeds, >> > > >> >> >> the correct HI

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
Hi again, On Thu, Feb 26, 2015 at 02:15:40PM -0600, Felipe Balbi wrote: > > > >> >> > On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: > > > >> >> >> FSDEV is set for both HIGH and FULL speeds, > > > >> >> >> the correct HIGHSPEED check is done through > > > >> >> >> power register's

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
Hi, On Thu, Feb 26, 2015 at 02:11:15PM -0600, Felipe Balbi wrote: > On Thu, Feb 26, 2015 at 02:04:37PM -0600, Bin Liu wrote: > > On Thu, Feb 26, 2015 at 1:59 PM, Felipe Balbi wrote: > > > On Thu, Feb 26, 2015 at 01:49:51PM -0600, Bin Liu wrote: > > >> On Thu, Feb 26, 2015 at 1:48 PM, Felipe Balbi

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
On Thu, Feb 26, 2015 at 02:04:37PM -0600, Bin Liu wrote: > On Thu, Feb 26, 2015 at 1:59 PM, Felipe Balbi wrote: > > On Thu, Feb 26, 2015 at 01:49:51PM -0600, Bin Liu wrote: > >> On Thu, Feb 26, 2015 at 1:48 PM, Felipe Balbi wrote: > >> > On Thu, Feb 26, 2015 at 01:30:21PM -0600, Bin Liu wrote: >

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Bin Liu
On Thu, Feb 26, 2015 at 2:04 PM, Bin Liu wrote: > On Thu, Feb 26, 2015 at 1:59 PM, Felipe Balbi wrote: >> On Thu, Feb 26, 2015 at 01:49:51PM -0600, Bin Liu wrote: >>> On Thu, Feb 26, 2015 at 1:48 PM, Felipe Balbi wrote: >>> > On Thu, Feb 26, 2015 at 01:30:21PM -0600, Bin Liu wrote: >>> >> Felipe

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Bin Liu
On Thu, Feb 26, 2015 at 1:59 PM, Felipe Balbi wrote: > On Thu, Feb 26, 2015 at 01:49:51PM -0600, Bin Liu wrote: >> On Thu, Feb 26, 2015 at 1:48 PM, Felipe Balbi wrote: >> > On Thu, Feb 26, 2015 at 01:30:21PM -0600, Bin Liu wrote: >> >> Felipe, >> >> >> >> On Thu, Feb 26, 2015 at 12:27 PM, Felipe

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
On Thu, Feb 26, 2015 at 01:49:51PM -0600, Bin Liu wrote: > On Thu, Feb 26, 2015 at 1:48 PM, Felipe Balbi wrote: > > On Thu, Feb 26, 2015 at 01:30:21PM -0600, Bin Liu wrote: > >> Felipe, > >> > >> On Thu, Feb 26, 2015 at 12:27 PM, Felipe Balbi wrote: > >> > On Thu, Feb 26, 2015 at 12:25:16PM -0600

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
On Thu, Feb 26, 2015 at 01:30:21PM -0600, Bin Liu wrote: > Felipe, > > On Thu, Feb 26, 2015 at 12:27 PM, Felipe Balbi wrote: > > On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: > >> FSDEV is set for both HIGH and FULL speeds, > >> the correct HIGHSPEED check is done through > >> pow

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Bin Liu
On Thu, Feb 26, 2015 at 1:48 PM, Felipe Balbi wrote: > On Thu, Feb 26, 2015 at 01:30:21PM -0600, Bin Liu wrote: >> Felipe, >> >> On Thu, Feb 26, 2015 at 12:27 PM, Felipe Balbi wrote: >> > On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: >> >> FSDEV is set for both HIGH and FULL speed

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Bin Liu
Felipe, On Thu, Feb 26, 2015 at 12:27 PM, Felipe Balbi wrote: > On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: >> FSDEV is set for both HIGH and FULL speeds, >> the correct HIGHSPEED check is done through >> power register's HSMODE bit. >> >> Signed-off-by: Felipe Balbi > > I'm st

Re: [PATCH v2 03/15] usb: musb: core: fix highspeed check

2015-02-26 Thread Felipe Balbi
On Thu, Feb 26, 2015 at 12:25:16PM -0600, Felipe Balbi wrote: > FSDEV is set for both HIGH and FULL speeds, > the correct HIGHSPEED check is done through > power register's HSMODE bit. > > Signed-off-by: Felipe Balbi I'm still unsure if we should really ignore babble on FS/LS. It seems to me we