Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-31 Thread Mathias Nyman
On 30.05.2018 22:05, Adam Wallis wrote: Mathias, On 5/22/2018 2:55 PM, Adam Wallis wrote: The xhci driver forces DMA memory to be node aware, however, there are several ring-related memory allocations that are not memory node aware. This patch resolves those *alloc functions to be allocated on

Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-30 Thread Adam Wallis
Mathias, On 5/22/2018 2:55 PM, Adam Wallis wrote: > The xhci driver forces DMA memory to be node aware, however, there are > several ring-related memory allocations that are not memory node aware. > This patch resolves those *alloc functions to be allocated on the proper > memory node. > > Signed

Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-22 Thread Adam Wallis
On 5/22/2018 6:46 PM, Timur Tabi wrote: > On 5/22/18 1:55 PM, Adam Wallis wrote: >> +    struct device *dev = xhci_to_hcd(xhci)->self.sysdev; > > Since you only use 'dev' to get the NUMA node, you might want to consider this > instead: > > int node = dev_to_node(xhci_to_hcd(xhci)->self.sysdev

Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-22 Thread Timur Tabi
On 5/22/18 1:55 PM, Adam Wallis wrote: + struct device *dev = xhci_to_hcd(xhci)->self.sysdev; Since you only use 'dev' to get the NUMA node, you might want to consider this instead: int node = dev_to_node(xhci_to_hcd(xhci)->self.sysdev); -- Qualcomm Datacenter Technologies, In