Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Alexandre Belloni
Hi, For the next revision, please include the changelog after the --- marker and before the diffstat. Else, this looks good to me, with the same comment as Boris on the PLLB gating. We will take care of that later. Regards On 07/08/2014 at 17:23:58 +0200, Ronald Wahl wrote : > Hi, > > actually

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Sergei Shtylyov
Hello. On 08/07/2014 07:11 PM, Ronald Wahl wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in Please also specify that commit's summary in parens. interrupt context. This is not allowed as it might sleep. Move clock preparation and setting clock rate into p

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Ronald Wahl
Hi, actually this should have been patch v3 and not v2. Anyway, the major difference is that I moved setting the clock rate into process context as well as it may also sleep. - ron On 07.08.2014 17:11, Ronald Wahl wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparatio

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Boris BREZILLON
On Thu, 07 Aug 2014 14:43:32 +0200 Ronald Wahl wrote: > On 07.08.2014 09:59, Boris BREZILLON wrote: > > On Thu, 7 Aug 2014 09:52:31 +0200 > > Boris BREZILLON wrote: > >> On Wed, 6 Aug 2014 15:11:42 +0200 > >> Ronald Wahl wrote: > >> > >>> Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added c

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Ronald Wahl
On 07.08.2014 09:59, Boris BREZILLON wrote: On Thu, 7 Aug 2014 09:52:31 +0200 Boris BREZILLON wrote: On Wed, 6 Aug 2014 15:11:42 +0200 Ronald Wahl wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in interrupt context. This is not allowed as it might sleep. Move

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Boris BREZILLON
Adding USB and Atmel Maintainers in Cc. On Thu, 7 Aug 2014 09:52:31 +0200 Boris BREZILLON wrote: > Hi Ronald, > > On Wed, 6 Aug 2014 15:11:42 +0200 > Ronald Wahl wrote: > > > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in > > interrupt context. This is not allowed