Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-07-09 Thread Martin Kepplinger
Am 2016-07-08 um 23:08 schrieb Dmitry Torokhov: > On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: >> Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: >>> Hi Martin, >>> >>> On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: static int pegasus_reset_resume(str

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-07-08 Thread Dmitry Torokhov
On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: > Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > > Hi Martin, > > > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: > >> static int pegasus_reset_resume(struct usb_interface *intf) > >> { > >> + struct pe

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-06-28 Thread Martin Kepplinger
Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > Hi Martin, > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: >> static int pegasus_reset_resume(struct usb_interface *intf) >> { >> +struct pegasus *pegasus = usb_get_intfdata(intf); >> + >> +if (pegasus->dev->users)

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-06-23 Thread Dmitry Torokhov
Hi Martin, On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: > static int pegasus_reset_resume(struct usb_interface *intf) > { > + struct pegasus *pegasus = usb_get_intfdata(intf); > + > + if (pegasus->dev->users) > + pegasus_set_mode(pegasus, PEN_MODE_XY, NO

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 13:20 +0200, Martin Kepplinger wrote: > * Fix usb_autopm calls to be balanced > * In reset_resume() we need to set the device mode > * In suspend() we must cancel the workqueue's work > > Signed-off-by: Martin Kepplinger Looks good to me. Regards