Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-24 Thread Johan Hovold
On Tue, Jun 24, 2014 at 03:10:43PM +0200, Bjørn Mork wrote: > Johan Hovold writes: > > > This is a non-standard attribute of this particular laptop. It has three > > individual LEDs that can be enabled separately (using standard LED class > > attributes), but they will all three be in the same "m

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-24 Thread Bjørn Mork
Johan Hovold writes: > This is a non-standard attribute of this particular laptop. It has three > individual LEDs that can be enabled separately (using standard LED class > attributes), but they will all three be in the same "mode" (which here > apparently means that they can be fully on, vary wi

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Johan Hovold
On Mon, Jun 23, 2014 at 04:24:48PM -0400, Greg KH wrote: > On Mon, Jun 23, 2014 at 09:52:12PM +0200, Johan Hovold wrote: > > On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote: > > > On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote: > > > > On Mon, Jun 23, 2014 at 02:24:32PM -0400,

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 09:52:12PM +0200, Johan Hovold wrote: > On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote: > > On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote: > > > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote: > > > > On Mon, Jun 23, 2014 at 02:23:24PM -0400,

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Johan Hovold
On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote: > On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote: > > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote: > > > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote: > > > > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Jann

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote: > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote: > > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote: > > > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > > > > + ret = sysfs_create_group(&led

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Johan Hovold
On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote: > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote: > > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > > > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group); > > > + if (ret) { > > > +

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group); > + if (ret) { > + hid_err(hdev, "failed to create sysfs attributes\n"); > + goto fail; > + } No, you need to set the att

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote: > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group); > > + if (ret) { > > + hid_err(hdev, "failed to create sysfs attributes\n"); > > +

Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-23 Thread Johan Hovold
On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in > MSI GT683R laptop > > Signed-off-by: Janne Kanniainen > --- > Changes in v2: > - sorted headers to alphabetic order > - using devm_kzalloc >