Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 5, 2018 at 3:57 AM Chen Yu wrote: > On 2018/12/5 1:47, Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: > >> On 2018/12/3 17:23, Andy Shevchenko wrote: > >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > > > + .of_match_table = of_match_pt

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-04 Thread Chen Yu
Hi, On 2018/12/5 1:47, Andy Shevchenko wrote: > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: >> On 2018/12/3 17:23, Andy Shevchenko wrote: >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), >>> >>> Does it compiles

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: > On 2018/12/3 17:23, Andy Shevchenko wrote: > > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > >> + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), > > > > Does it compiles for non-OF case? Why macro is in use? > OK. I will

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-03 Thread Chen Yu
Hi, On 2018/12/3 17:23, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: >> >> This driver handles usb hub power on and typeC port event of HiKey960 board: >> 1)DP&DM switching between usb hub and typeC port base on typeC port >> state >> 2)Control power of usb hub on Hikey9

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > +config HISI_HIKEY