Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-25 Thread Bjørn Mork
Oliver Neukum writes: > On Friday 25 January 2013 08:13:15 Bjørn Mork wrote: >> Oliver Neukum writes: >> > On Thursday 24 January 2013 20:16:56 Bjørn Mork wrote: >> >> A device sending 0 length frames as fast as it can has been >> >> observed killing the host system due to the resulting memory >>

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-25 Thread Oliver Neukum
On Friday 25 January 2013 08:13:15 Bjørn Mork wrote: > Oliver Neukum writes: > > On Thursday 24 January 2013 20:16:56 Bjørn Mork wrote: > >> A device sending 0 length frames as fast as it can has been > >> observed killing the host system due to the resulting memory > >> pressure. > >> > >> Tempo

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-25 Thread Bjørn Mork
Joe Perches writes: > On Thu, 2013-01-24 at 20:16 +0100, Bjørn Mork wrote: >> A device sending 0 length frames as fast as it can has been >> observed killing the host system due to the resulting memory >> pressure. > [] >> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > [] >> @

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Bjørn Mork
Oliver Neukum writes: > On Thursday 24 January 2013 20:16:56 Bjørn Mork wrote: >> A device sending 0 length frames as fast as it can has been >> observed killing the host system due to the resulting memory >> pressure. >> >> Temporarily disable RX skb allocation and URB submission when >> the cur

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Joe Perches
On Thu, 2013-01-24 at 20:16 +0100, Bjørn Mork wrote: > A device sending 0 length frames as fast as it can has been > observed killing the host system due to the resulting memory > pressure. [] > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c [] > @@ -539,6 +545,22 @@ block: >

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Oliver Neukum
On Thursday 24 January 2013 20:16:56 Bjørn Mork wrote: > A device sending 0 length frames as fast as it can has been > observed killing the host system due to the resulting memory > pressure. > > Temporarily disable RX skb allocation and URB submission when > the current error ratio is high, preve