Oliver Neukum writes:
> On Monday 21 January 2013 16:28:48 Bjørn Mork wrote:
>
>> Agreed. But I believe the condition should be
>>
>> if (!(info->flags & FLAG_SEND_ZLP) && !(info->flags & FLAG_MULTI_PACKET)) {
>> ..
>> } else {
>> urb->transfer_flags |= URB_ZERO_PACKET;
>> }
>>
>>
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote:
> > > Either the FLAG_MULTI_PACKET minidriver will have already padded the
> > > buffer so that we do not hit (length % dev->maxpacket == 0), or we
> > > should choose one of the alternatives: ZLP or padding.
> >
> > But we cannot simply ca
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote:
> Specification says:
> NCM/MBIM shall not send ZLP if buffer size is dwNtbOutMaxSize.
>
> The problem is:
> dwNtbOutMaxSize value is negotiated between host and device NCM/MBIM
> entities and usbnet has no knowledge about it.
>
> Adding
On Monday 21 January 2013 16:28:48 Bjørn Mork wrote:
> Agreed. But I believe the condition should be
>
> if (!(info->flags & FLAG_SEND_ZLP) && !(info->flags & FLAG_MULTI_PACKET)) {
> ..
> } else {
> urb->transfer_flags |= URB_ZERO_PACKET;
> }
>
> to ensure that we send the ZLP in
> -Original Message-
> From: Oliver Neukum [mailto:oneu...@suse.de]
> On Monday 21 January 2013 15:47:13 Bjørn Mork wrote:
> > But I wonder if this isn't really a generic problem in usbnet. The
> > FLAG_MULTI_PACKET test here seems completely bogus:
> >
> > if (length % dev->maxpac
Oliver Neukum writes:
> On Monday 21 January 2013 15:47:13 Bjørn Mork wrote:
>> But I wonder if this isn't really a generic problem in usbnet. The
>> FLAG_MULTI_PACKET test here seems completely bogus:
>>
>> if (length % dev->maxpacket == 0) {
>> if (!(info->flags & FLAG_
On Monday 21 January 2013 15:47:13 Bjørn Mork wrote:
> But I wonder if this isn't really a generic problem in usbnet. The
> FLAG_MULTI_PACKET test here seems completely bogus:
>
> if (length % dev->maxpacket == 0) {
> if (!(info->flags & FLAG_SEND_ZLP)) {
>
Bjørn Mork writes:
> I have another issue with the Sierra firmware which I hope you can help
> me with: The MC7710 device requires at ZLP even if we send
> dwNtbOutMaxSize sized NTBs. This is a problem because the current code
> explicitly prevents this.
If anyone found this more than normally c
Hello Alexey,
I have another issue with the Sierra firmware which I hope you can help
me with: The MC7710 device requires at ZLP even if we send
dwNtbOutMaxSize sized NTBs. This is a problem because the current code
explicitly prevents this.
The following code in the v3.8 cdc-ncm was written to k
Alexey Orishko writes:
> On Fri, Jan 18, 2013 at 10:17 PM, Bjørn Mork wrote:
>
Some Sierra Wireless firmwares support CDC MBIM but have no CDC
Union funtional descriptor. This violates the MBIM specification,
>
> I don't believe Sierra Wireless violates MBIM specification.
> See in the
On Fri, Jan 18, 2013 at 10:17 PM, Bjørn Mork wrote:
>>> Some Sierra Wireless firmwares support CDC MBIM but have no CDC
>>> Union funtional descriptor. This violates the MBIM specification,
I don't believe Sierra Wireless violates MBIM specification.
See in the specification: "there are two ways
>+ for (i = 0; i < USB_MAXIADS; i++) {
>+ iad = udev->actconfig->intf_assoc[i];
>+ if (iad->bFirstInterface == mnum && iad->bInterfaceCount == 2)
>+ return usb_ifnum_to_if(udev, mnum + 1);
Ouch. This looks buggy. Please do not apply. I will sen
Oliver Neukum writes:
> On Friday 18 January 2013 15:25:47 Bjørn Mork wrote:
>> Adding support for the MBIM mode in some Sierra Wireless devices.
>>
>> Some Sierra Wireless firmwares support CDC MBIM but have no CDC
>> Union funtional descriptor. This violates the MBIM specification,
>> but we ca
On Friday 18 January 2013 15:25:47 Bjørn Mork wrote:
> Adding support for the MBIM mode in some Sierra Wireless devices.
>
> Some Sierra Wireless firmwares support CDC MBIM but have no CDC
> Union funtional descriptor. This violates the MBIM specification,
> but we can easily work around the bug b
14 matches
Mail list logo
