Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP

2015-03-16 Thread Peter Hung
Hello, Johan Hovold 於 2015/3/16 下午 04:52 寫道: On Mon, Mar 16, 2015 at 10:53:38AM +0800, Peter Hung wrote: To avoid confusing to user, I'll keep it without warning message. Yes, skip the warning, but could you a short comment about this (e.g. the 1-byte packet on open) before you do the size ch

Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP

2015-03-16 Thread Johan Hovold
On Mon, Mar 16, 2015 at 10:53:38AM +0800, Peter Hung wrote: > Hello, > > Johan Hovold 於 2015/3/14 下午 07:48 寫道: > > On Thu, Feb 26, 2015 at 06:02:08PM +0800, Peter Hung wrote: > >> - if (!urb->actual_length) > >> + if ((urb->actual_length < 2) || (urb->actual_length % 2)) > >>return;

Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP

2015-03-15 Thread Peter Hung
Hello, Johan Hovold 於 2015/3/14 下午 07:48 寫道: On Thu, Feb 26, 2015 at 06:02:08PM +0800, Peter Hung wrote: - if (!urb->actual_length) + if ((urb->actual_length < 2) || (urb->actual_length % 2)) return; Not parsing short data (e.g. not divisible by 2) is OK I guess. Y

Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP

2015-03-14 Thread Johan Hovold
On Thu, Feb 26, 2015 at 06:02:08PM +0800, Peter Hung wrote: > The F81232 bulk-in is RX data + LSR channel, data format is > [LSR+Data][LSR+Data]. , We had implemented in f81232_process_read_urb(). > > Signed-off-by: Peter Hung > static void f81232_process_read_urb(struct urb *urb) > { >