Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-22 Thread Roland Stigge
On 08/22/2012 01:56 PM, Sebastian Andrzej Siewior wrote: > On 08/22/2012 01:43 PM, Felipe Balbi wrote: >>> But now that I've seen the transceiver driver it is probably the >>> smallest one. >> >> if it depends on the transceiver, why do we have i2c transfers on those >> drivers ? They should be hid

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-22 Thread Felipe Balbi
On Wed, Aug 22, 2012 at 01:56:56PM +0200, Sebastian Andrzej Siewior wrote: > On 08/22/2012 01:43 PM, Felipe Balbi wrote: > >>But now that I've seen the transceiver driver it is probably the > >>smallest one. > > > >if it depends on the transceiver, why do we have i2c transfers on those > >drivers ?

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-22 Thread Sebastian Andrzej Siewior
On 08/22/2012 01:43 PM, Felipe Balbi wrote: But now that I've seen the transceiver driver it is probably the smallest one. if it depends on the transceiver, why do we have i2c transfers on those drivers ? They should be hidden by the usb_phy_*() calls. Unless Roland has other plans now I woul

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-22 Thread Felipe Balbi
On Fri, Aug 17, 2012 at 03:14:10PM +0200, Sebastian Andrzej Siewior wrote: > On 08/16/2012 11:31 AM, Roland Stigge wrote: > >USB_ISP1301 already depends on I2C. > > > >Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead > >of "select USB_ISP1301"? > > And your OHCI select has t

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-17 Thread Roland Stigge
Hi! On 08/17/2012 03:14 PM, Sebastian Andrzej Siewior wrote: > On 08/16/2012 11:31 AM, Roland Stigge wrote: >> USB_ISP1301 already depends on I2C. >> >> Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead >> of "select USB_ISP1301"? > > And your OHCI select has the same proble

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/16/2012 11:31 AM, Roland Stigge wrote: USB_ISP1301 already depends on I2C. Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead of "select USB_ISP1301"? And your OHCI select has the same problem. So we make both things depend on the transceiver instead of selecting it

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-16 Thread Roland Stigge
Hi, On 08/15/2012 09:59 PM, Sebastian Andrzej Siewior wrote: > | drivers/usb/gadget/lpc32xx_udc.c: In function ‘isp1301_udc_configure’: > | drivers/usb/gadget/lpc32xx_udc.c:606: error: implicit declaration of > function ‘i2c_smbus_write_byte_data’ > | drivers/usb/gadget/lpc32xx_udc.c:665: error: