Re: [PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

2018-10-12 Thread Ben Dooks
On 12/10/18 11:44, Bjørn Mork wrote: Ben Dooks writes: +static inline struct qmi_wwan_state *usbnet_to_qmi(struct usbnet *usb) +{ + return (void *) &usb->data; +} checkpatch doesn't like this, and it is also inconsistent with the coding style elsewhere in the driver. Thank you for p

Re: [PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

2018-10-12 Thread Bjørn Mork
Ben Dooks writes: > +static inline struct qmi_wwan_state *usbnet_to_qmi(struct usbnet *usb) > +{ > + return (void *) &usb->data; > +} checkpatch doesn't like this, and it is also inconsistent with the coding style elsewhere in the driver. CHECK: No space is necessary after a cast #30: FILE

Re: [PATCH 4/7] net: qmi_wwan: add usbnet -> priv function

2018-10-12 Thread Greg KH
On Fri, Oct 12, 2018 at 10:16:39AM +0100, Ben Dooks wrote: > There are a number of places in the qmi_wwan driver where it gets the > private-data from the usbnet passed in. It would be sensible to have > one inline function to convert it and change all points in the driver > to use that. > > Signe