RE: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-17 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Wednesday, April 17, 2013 10:15 AM ... > > > As you might gather from the above, I'm not really in the loop about how > > > the hardware works here, so I don't think I'm qualified to decide on the > > > best approach here... Perhaps I s

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-17 Thread Matthijs Kooijman
Hi Paul, > > > phy_type > > > phy_utmi_width > > > phy_ulpi_ddr > > > phy_ulpi_ext_vbus > > > i2c_enable > > > ulpi_fs_ls > > > host_support_fs_ls_low_power > > > host_ls_low_power_phy_clk > > > > > > The last 8 are related to the Phy. I wonder if they should be in a > > > separate

RE: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-12 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > > These are the core parameters that I think are needed right now: > > > > dma_enable > > dma_desc_enable > > host_rx_fifo_size > > host_nperio_tx_fifo_size > > host_perio_tx_fifo_size > > max_transfer_size > > ma

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-12 Thread Matthijs Kooijman
Hi Paul, > These are the core parameters that I think are needed right now: > > dma_enable > dma_desc_enable > host_rx_fifo_size > host_nperio_tx_fifo_size > host_perio_tx_fifo_size > max_transfer_size > max_packet_count > host_channels > > p

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-12 Thread Matthijs Kooijman
Hi Marc, > > /** > > + * dwc2_load_property() - Load a single property from the > > devicetree > > + * node into the given variable. > > + * > > + * @dev: Platform device > > + * @res: The variable to put the loaded value into > > + * @name: The name of the devicetree property to load > > + */ >

RE: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Thursday, April 11, 2013 1:20 PM > > > Sadly, a lot of these are actually required. But Matthijs, I believe > > several of these (otg-cap, otg-ver, ts-dline?) are only for peripheral > > mode, so they could be removed for now, and only b

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Matthijs Kooijman
Hi Paul, > Sadly, a lot of these are actually required. But Matthijs, I believe > several of these (otg-cap, otg-ver, ts-dline?) are only for peripheral > mode, so they could be removed for now, and only brought back if needed > when peripheral mode is implemented. And I think a couple of others >

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Michael Grzeschik
On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: > Each of the parameters in the dwc2_core_params struct can now be changed > using devicetree parameters. > > Signed-off-by: Matthijs Kooijman > --- > Documentation/devicetree/bindings/staging/dwc2.txt | 36 > drivers/s

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Felipe Balbi
On Thu, Apr 11, 2013 at 09:19:37PM +0200, Matthijs Kooijman wrote: > Hi Felipe, > > On Thu, Apr 11, 2013 at 09:39:26PM +0300, Felipe Balbi wrote: > > On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: > [devicetree params] > > > + - ahb-single > > > > are you 110% sure you want al

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Marc Kleine-Budde
On 04/11/2013 06:43 PM, Matthijs Kooijman wrote: > Each of the parameters in the dwc2_core_params struct can now be changed > using devicetree parameters. > > Signed-off-by: Matthijs Kooijman > --- > Documentation/devicetree/bindings/staging/dwc2.txt | 36 > drivers/staging/dwc2/platfo

RE: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, April 11, 2013 11:39 AM > > On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: > > diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt > > b/Documentation/devicetree/bindings/staging/dwc2.txt > > index 3649c8

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Matthijs Kooijman
Hi Felipe, On Thu, Apr 11, 2013 at 09:39:26PM +0300, Felipe Balbi wrote: > On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: [devicetree params] > > + - ahb-single > > are you 110% sure you want all of these parameters ? You will have to > support them forever once it gets accept

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: > diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt > b/Documentation/devicetree/bindings/staging/dwc2.txt > index 3649c88..05d9c08 100644 > --- a/Documentation/devicetree/bindings/staging/dwc2.txt > +++ b/Docume