Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Alan Stern
On Sat, 6 Apr 2013, Sergei Shtylyov wrote: > On 04/06/2013 12:56 AM, Alan Stern wrote: > > And instead of passing hcd->regs, wouldn't it be better to pass hcd? > >>> I really don't know. > >>> > Other users of this interface might need to initialize something other > than a non

Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Sergei Shtylyov
On 04/06/2013 12:56 AM, Alan Stern wrote: And instead of passing hcd->regs, wouldn't it be better to pass hcd? I really don't know. Other users of this interface might need to initialize something other than a non-standard register. Hm, maybe... if passing 'struct usb_hcd *' would in

Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Alan Stern
On Sat, 6 Apr 2013, Sergei Shtylyov wrote: > On 04/06/2013 12:40 AM, Sergei Shtylyov wrote: > > > > >> And instead of passing hcd->regs, wouldn't it be better to pass hcd? > > > >I really don't know. > > > >> Other users of this interface might need to initialize something other > >> than a n

Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Alan Stern
On Sat, 6 Apr 2013, Sergei Shtylyov wrote: > > And instead of passing hcd->regs, wouldn't it be better to pass hcd? > > I really don't know. > > > Other users of this interface might need to initialize something other > > than a non-standard register. > > Hm, maybe... if passing 'struct

Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Sergei Shtylyov
On 04/06/2013 12:40 AM, Sergei Shtylyov wrote: And instead of passing hcd->regs, wouldn't it be better to pass hcd? I really don't know. Other users of this interface might need to initialize something other than a non-standard register. Hm, maybe... if passing 'struct usb_hcd *' w

Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Sergei Shtylyov
Hello. On 04/05/2013 06:43 PM, Alan Stern wrote: Sometimes there is a need to initialize some non-standard registers mapped to the EHCI region before accessing the standard EHCI registers. Add the init() method to the 'ehci-platform' platform data for this purpose. "init" isn't such a good

Re: [PATCH 2/8] ehci-platform: add init() method to platform data

2013-04-05 Thread Alan Stern
On Fri, 5 Apr 2013, Sergei Shtylyov wrote: > Sometimes there is a need to initialize some non-standard registers mapped to > the EHCI region before accessing the standard EHCI registers. Add the init() > method to the 'ehci-platform' platform data for this purpose. "init" isn't such a good name