Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-14 Thread Bin Liu
Sebastian, On Wed, Aug 14, 2013 at 2:16 AM, Sebastian Andrzej Siewior wrote: > On 08/13/2013 08:11 PM, Bin Liu wrote: >> Sebastian, > > Hi Bin, > >> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior >> wrote: >>> Since the musb-gadget code now calls the dma engine properly it is >>> po

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2013 11:19 PM, Felipe Balbi wrote: > true, I'm sure Sebastian has plans on adding RX support, but only > after he knows it's working fine ;-) I actually have none. I am not sure how likely it is that this bug will trigger in device I just have the errata. Usually there is at least one cus

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2013 09:21 PM, Felipe Balbi wrote: >> 1.0.13 only presents in PG1.0. It has been fixed in PG2.x. Maybe >> we should check for silicon rev here? > > it would be quite difficult to check PG revision from this driver. > It would have to be passed as a flag through DT or something > similar.

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2013 08:11 PM, Bin Liu wrote: > Sebastian, Hi Bin, > On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior > wrote: >> Since the musb-gadget code now calls the dma engine properly it is >> possible to enable it for the TX path in device mode. >> AM335x Advisory 1.0.13 says that we

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-13 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 04:17:26PM -0500, Bin Liu wrote: > On Tue, Aug 13, 2013 at 4:13 PM, Felipe Balbi wrote: > > On Tue, Aug 13, 2013 at 03:41:01PM -0500, Bin Liu wrote: > >> On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote: > >> > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote: >

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-13 Thread Bin Liu
On Tue, Aug 13, 2013 at 4:13 PM, Felipe Balbi wrote: > On Tue, Aug 13, 2013 at 03:41:01PM -0500, Bin Liu wrote: >> On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote: >> > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote: >> >> Sebastian, >> >> >> >> On Tue, Aug 13, 2013 at 12:38 PM, Seba

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-13 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 03:41:01PM -0500, Bin Liu wrote: > On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote: > > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote: > >> Sebastian, > >> > >> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior > >> wrote: > >> > Since the musb-gadg

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-13 Thread Bin Liu
On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote: > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote: >> Sebastian, >> >> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior >> wrote: >> > Since the musb-gadget code now calls the dma engine properly it is >> > possible to enable

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-13 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote: > Sebastian, > > On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior > wrote: > > Since the musb-gadget code now calls the dma engine properly it is > > possible to enable it for the TX path in device mode. > > AM335x Advisory 1.0.1

Re: [PATCH 2/2] usb: musb: cppi41: Enable in device-TX mode

2013-08-13 Thread Bin Liu
Sebastian, On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior wrote: > Since the musb-gadget code now calls the dma engine properly it is > possible to enable it for the TX path in device mode. > AM335x Advisory 1.0.13 says that we may lose the toggle bit on multiple > RX transfers. Ther