Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-24 Thread Matthieu CASTET
Hi, Le Tue, 23 Jan 2018 11:24:05 +0100, Greg Kroah-Hartman a écrit : > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_RW() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to

Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-23 Thread Bin Liu
On Tue, Jan 23, 2018 at 11:24:05AM +0100, Greg Kroah-Hartman wrote: > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_RW() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to a sc

Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-23 Thread Alan Stern
On Tue, 23 Jan 2018, Greg Kroah-Hartman wrote: > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_RW() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to a script from Joe Perche

Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-23 Thread Greg Kroah-Hartman
On Tue, Jan 23, 2018 at 12:26:38PM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > > Instead of "open coding" a DEVICE_ATTR() define, use the > > DEVICE_ATTR_RW() macro instead, which does everything properly instead. > > > > This does require a few static functions to be ren

Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-23 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_RW() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to a script from Joe Perches, this was eas