Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-01 Thread Bin Liu
Hi Rob, On Wed, Feb 17, 2016 at 12:51:34PM -0600, Rob Herring wrote: > On Wed, Feb 17, 2016 at 12:14 PM, Sergei Shtylyov > wrote: > > On 02/16/2016 11:05 PM, Rob Herring wrote: > > > > + - mentor,power : Specifies the maximum current in milliamperes the > > controller can > > + su

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-24 Thread Sergei Shtylyov
Hello. Sorry about late reply, I kept forgetting about this mail. On 02/17/2016 09:51 PM, Rob Herring wrote: + - mentor,power : Specifies the maximum current in milliamperes the controller can + supply in host mode. Still a no for me. Looks like this just sets hcd->power_budget. This

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-17 Thread Rob Herring
On Wed, Feb 17, 2016 at 12:14 PM, Sergei Shtylyov wrote: > On 02/16/2016 11:05 PM, Rob Herring wrote: > > + - mentor,power : Specifies the maximum current in milliamperes the > controller can > + supply in host mode. Still a no for me. Looks like this just sets hcd->

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-17 Thread Sergei Shtylyov
On 02/16/2016 11:05 PM, Rob Herring wrote: + - mentor,power : Specifies the maximum current in milliamperes the controller can + supply in host mode. Still a no for me. Looks like this just sets hcd->power_budget. This property may not be a regulator, but ultimately the value depends on so

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-17 Thread Sergei Shtylyov
Hello. On 02/16/2016 10:53 PM, Rob Herring wrote: This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 1006

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-17 Thread Petr Kulhavy
Hello Rob, On 16.02.2016 21:05, Rob Herring wrote: On Fri, Feb 12, 2016 at 11:24 AM, Petr Kulhavy wrote: I understand your point that the description should be generic. However the USB 2.0 specification does not define any relation between the bMaxPower provided by the device and the actual po

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-16 Thread Rob Herring
On Fri, Feb 12, 2016 at 11:24 AM, Petr Kulhavy wrote: > > On 12.02.2016 17:21, Rob Herring wrote: >> >> On Thu, Feb 11, 2016 at 12:01:06PM +0100, Petr Kulhavy wrote: >>> >>> + - mentor,power : Specifies the maximum current in milliamperes the >>> controller can >>> + supply in host mode. >> >>

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-16 Thread Rob Herring
On Fri, Feb 12, 2016 at 11:26 AM, Sergei Shtylyov wrote: > Hello. > > > On 02/12/2016 07:21 PM, Rob Herring wrote: > >>> This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. >>> >>> Signed-off-by: Petr Kulhavy >>> --- >>> .../devicetree/bindings/usb/da8xx-usb.txt |

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-16 Thread Petr Kulhavy
Hello Rob, is there any follow-up on this one? Thanks Petr On 12.02.2016 18:24, Petr Kulhavy wrote: On 12.02.2016 17:21, Rob Herring wrote: On Thu, Feb 11, 2016 at 12:01:06PM +0100, Petr Kulhavy wrote: + - mentor,power : Specifies the maximum current in milliamperes the controller can +

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-12 Thread Sergei Shtylyov
Hello. On 02/12/2016 07:21 PM, Rob Herring wrote: This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-12 Thread Petr Kulhavy
On 12.02.2016 17:21, Rob Herring wrote: On Thu, Feb 11, 2016 at 12:01:06PM +0100, Petr Kulhavy wrote: + - mentor,power : Specifies the maximum current in milliamperes the controller can + supply in host mode. Still a no for me. Looks like this just sets hcd->power_budget. This property ma

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-12 Thread Rob Herring
On Thu, Feb 11, 2016 at 12:01:06PM +0100, Petr Kulhavy wrote: > This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. > > Signed-off-by: Petr Kulhavy > --- > .../devicetree/bindings/usb/da8xx-usb.txt | 47 > ++ > 1 file changed, 47 insertions(+)

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-11 Thread Sergei Shtylyov
On 02/11/2016 06:01 PM, Petr Kulhavy wrote: +ti,phy20-clkmux-pll; +ti,phy20-refclock-frequency = <2400>; In principle these 2 should belong to the USB PHY subnode... Do you mean to define a PHY subnode even if there is currently no standalone PHY driver for da8xx?

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-11 Thread Petr Kulhavy
On 11.02.2016 14:53, Sergei Shtylyov wrote: +ti,phy20-clkmux-pll; +ti,phy20-refclock-frequency = <2400>; In principle these 2 should belong to the USB PHY subnode... Do you mean to define a PHY subnode even if there is currently no standalone PHY driver for da8xx?

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-11 Thread Sergei Shtylyov
Hello. On 2/11/2016 2:01 PM, Petr Kulhavy wrote: This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. This patch describes bindings, not adds support. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 47 ++