Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-04-05 Thread Peter Chen
On Mon, Mar 14, 2016 at 6:42 PM, Peter Chen wrote: > On Sat, Mar 05, 2016 at 03:10:11PM +0100, Andrew Lunn wrote: >> > So, would you like to accept the generic solution like below: >> > >> > - Create a generic power sequence driver, and it will be probed >> > according to compatible string at devi

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-14 Thread Peter Chen
On Sat, Mar 05, 2016 at 03:10:11PM +0100, Andrew Lunn wrote: > > So, would you like to accept the generic solution like below: > > > > - Create a generic power sequence driver, and it will be probed > > according to compatible string at device tree. At its probe, > > we can create a power sequence

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-05 Thread Andrew Lunn
> So, would you like to accept the generic solution like below: > > - Create a generic power sequence driver, and it will be probed > according to compatible string at device tree. At its probe, > we can create a power sequence structure, and let this structure > as the private data for this power

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-05 Thread Peter Chen
On Fri, Mar 04, 2016 at 10:28:54PM -0600, Rob Herring wrote: > On Fri, Mar 04, 2016 at 10:37:50AM +0800, Peter Chen wrote: > > On Fri, Mar 04, 2016 at 03:23:05AM +0100, Andrew Lunn wrote: > > > On Fri, Mar 04, 2016 at 10:02:42AM +0800, Peter Chen wrote: > > > > On Thu, Mar 03, 2016 at 02:54:55PM -0

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-04 Thread Rob Herring
On Fri, Mar 04, 2016 at 10:37:50AM +0800, Peter Chen wrote: > On Fri, Mar 04, 2016 at 03:23:05AM +0100, Andrew Lunn wrote: > > On Fri, Mar 04, 2016 at 10:02:42AM +0800, Peter Chen wrote: > > > On Thu, Mar 03, 2016 at 02:54:55PM -0600, Rob Herring wrote: > > > > On Thu, Mar 3, 2016 at 4:01 AM, Peter

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-03 Thread Peter Chen
On Fri, Mar 04, 2016 at 03:23:05AM +0100, Andrew Lunn wrote: > On Fri, Mar 04, 2016 at 10:02:42AM +0800, Peter Chen wrote: > > On Thu, Mar 03, 2016 at 02:54:55PM -0600, Rob Herring wrote: > > > On Thu, Mar 3, 2016 at 4:01 AM, Peter Chen wrote: > > > > Some hard-wired USB devices need to do power s

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-03 Thread Andrew Lunn
On Fri, Mar 04, 2016 at 10:02:42AM +0800, Peter Chen wrote: > On Thu, Mar 03, 2016 at 02:54:55PM -0600, Rob Herring wrote: > > On Thu, Mar 3, 2016 at 4:01 AM, Peter Chen wrote: > > > Some hard-wired USB devices need to do power sequence to let the > > > device work normally, the typical power sequ

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-03 Thread Peter Chen
On Thu, Mar 03, 2016 at 01:31:56PM -0500, Alan Stern wrote: > On Thu, 3 Mar 2016, Peter Chen wrote: > > > Some hard-wired USB devices need to do power sequence to let the > > device work normally, the typical power sequence like: enable USB > > PHY clock, toggle reset pin, etc. But current Linux U

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-03 Thread Peter Chen
On Thu, Mar 03, 2016 at 02:54:55PM -0600, Rob Herring wrote: > On Thu, Mar 3, 2016 at 4:01 AM, Peter Chen wrote: > > Some hard-wired USB devices need to do power sequence to let the > > device work normally, the typical power sequence like: enable USB > > PHY clock, toggle reset pin, etc. But curr

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-03 Thread Rob Herring
On Thu, Mar 3, 2016 at 4:01 AM, Peter Chen wrote: > Some hard-wired USB devices need to do power sequence to let the > device work normally, the typical power sequence like: enable USB > PHY clock, toggle reset pin, etc. But current Linux USB driver > lacks of such code to do it, it may cause some

Re: [PATCH 1/3] usb: core: add power sequence for USB devices

2016-03-03 Thread Alan Stern
On Thu, 3 Mar 2016, Peter Chen wrote: > Some hard-wired USB devices need to do power sequence to let the > device work normally, the typical power sequence like: enable USB > PHY clock, toggle reset pin, etc. But current Linux USB driver > lacks of such code to do it, it may cause some hard-wired