Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-08 Thread Alan Stern
On Tue, 7 Jan 2014, Hans de Goede wrote: > Hi, > > On 01/07/2014 10:16 PM, Arnd Bergmann wrote: > > On Tuesday 07 January 2014 22:03:11 Hans de Goede wrote: > + > +Optional properties: > + - clocks: array of clocks > + - clock-names: clock names "ahb" and/or "ohci" > >>> > >>>

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-08 Thread Hans de Goede
Hi, On 01/06/2014 08:50 AM, Hans de Goede wrote: Otherwise you don't know the difference between "no clock provided", "error getting the clock reference" and "clock controller not initialized yet, try again". I guess of these 3 we really only want to continue on "no clock provided", so I th

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-07 Thread Hans de Goede
Hi, On 01/07/2014 10:16 PM, Arnd Bergmann wrote: On Tuesday 07 January 2014 22:03:11 Hans de Goede wrote: + +Optional properties: + - clocks: array of clocks + - clock-names: clock names "ahb" and/or "ohci" Where does "ahb" come from, what does it mean, and how is it relevant to generic platf

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014 22:03:11 Hans de Goede wrote: > >> + > >> +Optional properties: > >> + - clocks: array of clocks > >> + - clock-names: clock names "ahb" and/or "ohci" > > > > Where does "ahb" come from, what does it mean, and how is it relevant > > to generic platforms? > > ahb is an AR

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-07 Thread Hans de Goede
Hi, On 01/06/2014 04:45 PM, Mark Rutland wrote: On Sun, Jan 05, 2014 at 11:04:39PM +, Hans de Goede wrote: Add support for ohci-platform instantiation from devicetree, including optionally getting clks and a phy from devicetree, and enabling / disabling those on power_on / off. This should

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-07 Thread Hans de Goede
Hi, On 01/06/2014 04:49 PM, Alan Stern wrote: On Mon, 6 Jan 2014, Hans de Goede wrote: Add support for ohci-platform instantiation from devicetree, including optionally getting clks and a phy from devicetree, and enabling / disabling those on power_on / off. This should allow using ohci-platf

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-06 Thread Arnd Bergmann
On Monday 06 January 2014, Hans de Goede wrote: > On 01/06/2014 08:16 AM, Arnd Bergmann wrote: > > On Monday 06 January 2014, Hans de Goede wrote: > >> +Required properties: > >> + - compatible: Should be "platform-ohci" > >> + - reg: Address range of the ohci registers. > >> + - interrupts: Should

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-06 Thread Alan Stern
On Mon, 6 Jan 2014, Hans de Goede wrote: > Add support for ohci-platform instantiation from devicetree, including > optionally getting clks and a phy from devicetree, and enabling / disabling > those on power_on / off. > > This should allow using ohci-platform from devicetree in various cases. >

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-06 Thread Mark Rutland
On Sun, Jan 05, 2014 at 11:04:39PM +, Hans de Goede wrote: > Add support for ohci-platform instantiation from devicetree, including > optionally getting clks and a phy from devicetree, and enabling / disabling > those on power_on / off. > > This should allow using ohci-platform from devicetree

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-05 Thread Hans de Goede
Hi, On 01/06/2014 08:16 AM, Arnd Bergmann wrote: On Monday 06 January 2014, Hans de Goede wrote: +Required properties: + - compatible: Should be "platform-ohci" + - reg: Address range of the ohci registers. + - interrupts: Should contain the ohci interrupt. + +Optional properties: + - clocks: a

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-05 Thread Arnd Bergmann
On Monday 06 January 2014, Hans de Goede wrote: > +Required properties: > + - compatible: Should be "platform-ohci" > + - reg: Address range of the ohci registers. > + - interrupts: Should contain the ohci interrupt. > + > +Optional properties: > + - clocks: array of clocks > + - clock-names: clock