Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-17 Thread Alan Stern
On Tue, 17 Feb 2015, Felipe Balbi wrote: > On Tue, Feb 17, 2015 at 09:55:21AM -0500, Alan Stern wrote: > > On Mon, 16 Feb 2015, Felipe Balbi wrote: > > > > > Electrical tests for resume signaling. It failed with a specific hub, > > > however :-) But it's easy to note with dwc3/musb and a USB snif

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-17 Thread Felipe Balbi
On Tue, Feb 17, 2015 at 09:55:21AM -0500, Alan Stern wrote: > On Mon, 16 Feb 2015, Felipe Balbi wrote: > > > Electrical tests for resume signaling. It failed with a specific hub, > > however :-) But it's easy to note with dwc3/musb and a USB sniffer. > > Sometimes resume signalling is cut before 2

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-17 Thread Alan Stern
On Mon, 16 Feb 2015, Felipe Balbi wrote: > Electrical tests for resume signaling. It failed with a specific hub, > however :-) But it's easy to note with dwc3/musb and a USB sniffer. > Sometimes resume signalling is cut before 20ms because we had msleep(20) > :-) Maybe that should be reported to

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-16 Thread Felipe Balbi
Hi, On Sun, Feb 15, 2015 at 09:06:15AM +0800, Peter Chen wrote: > On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > > On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > > > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > > > Every USB Host controller should

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-14 Thread Peter Chen
On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > > Every USB Host controller should use this new > > > macro to define for how long resume signalling > > > s

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-14 Thread Greg KH
On Fri, Feb 13, 2015 at 10:09:37PM -0600, Felipe Balbi wrote: > Greg, are you fine with v3.10+ ? I don't think it's worth backporting to > anything older than that because it's unlikely that there's current > development going on with those or products shipped with them have no > migration path to

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Felipe Balbi
On Fri, Feb 13, 2015 at 09:07:40PM -0600, Bin Liu wrote: > Greg, > > On Fri, Feb 13, 2015 at 8:41 PM, Greg KH wrote: > > On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > >> On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > >> > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Fel

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Bin Liu
Greg, On Fri, Feb 13, 2015 at 8:41 PM, Greg KH wrote: > On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: >> On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: >> > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: >> > > Every USB Host controller should use this new

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Greg KH
On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > > Every USB Host controller should use this new > > > macro to define for how long resume signalling > > > s

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Felipe Balbi
On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > Every USB Host controller should use this new > > macro to define for how long resume signalling > > should be driven on the bus. > > > > Currently, almost every single USB

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Greg KH
On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > Every USB Host controller should use this new > macro to define for how long resume signalling > should be driven on the bus. > > Currently, almost every single USB controller > is using a 20ms timeout for resume signalling. > > That

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Felipe Balbi
On Fri, Feb 13, 2015 at 04:22:12PM -0500, Alan Stern wrote: > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > Every USB Host controller should use this new > > macro to define for how long resume signalling > > should be driven on the bus. > > > > Currently, almost every single USB controller > >

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Alan Stern
On Fri, 13 Feb 2015, Felipe Balbi wrote: > Every USB Host controller should use this new > macro to define for how long resume signalling > should be driven on the bus. > > Currently, almost every single USB controller > is using a 20ms timeout for resume signalling. > > That's problematic for t

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-13 Thread Felipe Balbi
On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > Every USB Host controller should use this new > macro to define for how long resume signalling > should be driven on the bus. > > Currently, almost every single USB controller > is using a 20ms timeout for resume signalling. > > That