RE: [PATCH] xhci: make warnings greppable

2014-01-20 Thread David Laight
From: Sarah Sharp > This is fixed in the revised patch, David. Please read through the > entire thread before commenting, thanks. Sorry, I should have noticed that you said that you'd applied the 'checkpatch' fixes. I'm more or less forced to read these lists with outlook, it makes looking at th

Re: [PATCH] xhci: make warnings greppable

2014-01-17 Thread Sarah Sharp
On Fri, Jan 17, 2014 at 11:10:56AM +0100, Oliver Neukum wrote: > On Fri, 2014-01-17 at 09:58 +, David Laight wrote: > > From: Sarah Sharp > > > > >- xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed > > > > >because " > > > > >- "slot %u

Re: [PATCH] xhci: make warnings greppable

2014-01-17 Thread Oliver Neukum
On Fri, 2014-01-17 at 09:58 +, David Laight wrote: > From: Sarah Sharp > > > >-xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed > > > >because " > > > >-"slot %u was not enabled.\n", > > > >slot_id); > > > >+

RE: [PATCH] xhci: make warnings greppable

2014-01-17 Thread David Laight
From: Sarah Sharp > > >- xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed because > > >" > > >- "slot %u was not enabled.\n", slot_id); > > >+ xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed because > > >slot " > > >+

Re: [PATCH] xhci: make warnings greppable

2014-01-16 Thread Sarah Sharp
On Fri, Jan 10, 2014 at 01:36:17AM +0300, Sergei Shtylyov wrote: > Hello. > > On 01/08/2014 07:13 PM, oli...@neukum.org wrote: > > >From: Oliver Neukum > > >This changes debug messages and warnings in xhci-ring.c > >to be on a single line so grep can find them. grep must > >have precedence over

Re: [PATCH] xhci: make warnings greppable

2014-01-10 Thread Oliver Neukum
On Thu, 2014-01-09 at 13:18 -0800, Sarah Sharp wrote: > Hi Oliver, > > This looks fine, but it will have to wait until after the merge window, > as my tree is closed to cleanups/features right now. This will be > queued for 3.15. No problem. I had just suffered a fit of frustration for the reaso

Re: [PATCH] xhci: make warnings greppable

2014-01-09 Thread Sergei Shtylyov
Hello. On 01/08/2014 07:13 PM, oli...@neukum.org wrote: From: Oliver Neukum This changes debug messages and warnings in xhci-ring.c to be on a single line so grep can find them. grep must have precedence over the 80 column limit. In the eyes of checkpatch.pl, it has been having precede

Re: [PATCH] xhci: make warnings greppable

2014-01-09 Thread Sarah Sharp
Hi Oliver, This looks fine, but it will have to wait until after the merge window, as my tree is closed to cleanups/features right now. This will be queued for 3.15. Sarah Sharp On Wed, Jan 08, 2014 at 05:13:11PM +0100, oli...@neukum.org wrote: > From: Oliver Neukum > > This changes debug mes