Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

2015-02-21 Thread Aleksander Morgado
On Sat, Feb 21, 2015 at 4:34 PM, Alan Stern wrote: > On Sat, 21 Feb 2015, Aleksander Morgado wrote: > >> Probably didn't explain well, sorry, likely mixing terms. What I mean >> is that when the data length received is equal to the transfer buffer >> length, we get a single IRQ event saying COMP_S

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

2015-02-21 Thread Alan Stern
On Sat, 21 Feb 2015, Aleksander Morgado wrote: > Probably didn't explain well, sorry, likely mixing terms. What I mean > is that when the data length received is equal to the transfer buffer > length, we get a single IRQ event saying COMP_SUCCESS, with an event > len = 0; the URB length in that ca

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

2015-02-21 Thread Aleksander Morgado
Hey Alan, On Sat, Feb 21, 2015 at 3:47 AM, Alan Stern wrote: > On Sat, 21 Feb 2015, Aleksander Morgado wrote: > >> When the control TD doesn't have TRBs in the data stage, the URB actual >> length >> is set equal to the transfer buffer length. E.g. with a 64 byte transfer >> buffer >> length: >

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

2015-02-20 Thread Alan Stern
On Sat, 21 Feb 2015, Aleksander Morgado wrote: > When the control TD doesn't have TRBs in the data stage, the URB actual length > is set equal to the transfer buffer length. E.g. with a 64 byte transfer > buffer > length: > > Transfer event len = 0, COMP_SHORT_SUCCESS (status) >|-

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

2015-02-20 Thread Aleksander Morgado
On Sat, Feb 21, 2015 at 1:18 AM, Aleksander Morgado wrote: > The current logic, though, doesn't seem to contemplate the case where a TD > has a > TDR in the data stage which actually reports 0 bytes (i.e. transfer event len > equal to transfer buffer len). The logic is currently handling this cas