Re: [PATCH] usbhid: call report_fixup before comparing descriptors

2012-09-18 Thread Kevin Daughtridge
On 09/18/12 09:16 N.U., Henrik Rydberg wrote: You can use dev_rdesc here instead. Hi Henrik. Thanks for the tip. I tried comparing rdesc to hid->dev_rdesc without any report_fixup call, but the problem (device nonfunctional with "reset_resume error 1" message) still occurred. Upon looking at h

Re: [PATCH] usbhid: call report_fixup before comparing descriptors

2012-09-18 Thread Henrik Rydberg
Hi Kevin, > @@ -1436,6 +1436,10 @@ static int hid_post_reset(struct usb_int > kfree(rdesc); > return 1; > } > + > +if (hid->driver && hid->driver->report_fixup) > +rdesc = hid->driver->report_fixup(hid, rdesc, &status); > + > status = memcmp(rdesc, hid->rdes

Re: [PATCH] usbhid: call report_fixup before comparing descriptors

2012-09-18 Thread Sergei Shtylyov
Hello. On 18-09-2012 0:05, Kevin Daughtridge wrote: hid_post_reset checks the stored report descriptor against what is currently returned by the device. An HID driver's report_fixup method may have changed the stored descriptor, however, creating false positives. These leave some devices nonfun