RE: [PATCH] usb: xhci: ring: fix off-by-one error

2016-05-04 Thread David Laight
> From: Mathias Nyman > Sent: 03 May 2016 12:11 ... > > @@ -109,7 +109,7 @@ static int last_trb(struct xhci_hcd *xhci, struct > > xhci_ring *ring, > > struct xhci_segment *seg, union xhci_trb *trb) > > { > > if (ring == xhci->event_ring) > > - return trb == &seg->trbs[T

Re: [PATCH] usb: xhci: ring: fix off-by-one error

2016-05-03 Thread Felipe Balbi
Hi, Mathias Nyman writes: >> Mathias Nyman writes: >>> On 03.05.2016 13:30, Felipe Balbi wrote: When trying to access our last TRB, XHCI was actually reading memory outside of the TRB array/ring due to an off-by-one error. This patch fixes that error and has the side ef

Re: [PATCH] usb: xhci: ring: fix off-by-one error

2016-05-03 Thread Mathias Nyman
On 03.05.2016 14:55, Felipe Balbi wrote: Hi, Mathias Nyman writes: On 03.05.2016 13:30, Felipe Balbi wrote: When trying to access our last TRB, XHCI was actually reading memory outside of the TRB array/ring due to an off-by-one error. This patch fixes that error and has the side effect of a

Re: [PATCH] usb: xhci: ring: fix off-by-one error

2016-05-03 Thread Felipe Balbi
Hi, Mathias Nyman writes: > On 03.05.2016 13:30, Felipe Balbi wrote: >> When trying to access our last TRB, XHCI was >> actually reading memory outside of the TRB >> array/ring due to an off-by-one error. >> >> This patch fixes that error and has the side effect >> of also fixing some rare situa

Re: [PATCH] usb: xhci: ring: fix off-by-one error

2016-05-03 Thread Mathias Nyman
Hi On 03.05.2016 13:30, Felipe Balbi wrote: When trying to access our last TRB, XHCI was actually reading memory outside of the TRB array/ring due to an off-by-one error. This patch fixes that error and has the side effect of also fixing some rare situations where long mass storage transfers wo