Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-09 Thread Guenter Roeck
On 09/09/2018 07:36 AM, Angus Ainslie wrote: On 2018-09-09 08:20, Guenter Roeck wrote: On 09/09/2018 07:08 AM, Angus Ainslie wrote: Hi Guenter On 2018-09-07 06:55, Guenter Roeck wrote: On 09/07/2018 03:34 AM, Heikki Krogerus wrote: +Guenter On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ai

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-09 Thread Angus Ainslie
On 2018-09-09 08:20, Guenter Roeck wrote: On 09/09/2018 07:08 AM, Angus Ainslie wrote: Hi Guenter On 2018-09-07 06:55, Guenter Roeck wrote: On 09/07/2018 03:34 AM, Heikki Krogerus wrote: +Guenter On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote: If the board is being

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-09 Thread Guenter Roeck
On 09/09/2018 07:08 AM, Angus Ainslie wrote: Hi Guenter On 2018-09-07 06:55, Guenter Roeck wrote: On 09/07/2018 03:34 AM, Heikki Krogerus wrote: +Guenter On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-09 Thread Angus Ainslie
Hi Guenter On 2018-09-07 06:55, Guenter Roeck wrote: On 09/07/2018 03:34 AM, Heikki Krogerus wrote: +Guenter On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove power from the board. Default to

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-07 Thread Guenter Roeck
On 09/07/2018 03:34 AM, Heikki Krogerus wrote: +Guenter On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled. Seems to me that might viola

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-07 Thread Heikki Krogerus
+Guenter On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote: > If the board is being powered by USB disabling the source and sink > can remove power from the board. Default to source and sink enabled. > > Signed-off-by: Angus Ainslie (Purism) > --- > drivers/usb/typec/tcpm.c

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-07 Thread Sergei Shtylyov
Hello! On 9/6/2018 10:26 PM, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled. Signed-off-by: Angus Ainslie (Purism) --- drivers/usb/typec/tcpm.c | 8 +--- 1 file changed