Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-09 Thread Grygorii Strashko
On 12/08/2016 05:55 PM, Tony Lindgren wrote: > * Grygorii Strashko [161208 15:38]: >> On 12/08/2016 04:57 PM, Tony Lindgren wrote: >>> Seems to work based on few boot tests. Probably both should be applied, >>> my original patch to prevent spurious interrupts before things are >>> initialized, >

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-09 Thread Tony Lindgren
* Roger Quadros [161209 08:09]: > Hi Tony, > > On 08/12/16 05:21, Tony Lindgren wrote: > > Somehow starting with v4.9-rc7 there have been imprecise > > external aborts on omap5-uevm dwc3 controller. I have not been > > able to bisect what exactly triggered this as it does not always > > happen. I

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-09 Thread Roger Quadros
Hi Tony, On 08/12/16 05:21, Tony Lindgren wrote: > Somehow starting with v4.9-rc7 there have been imprecise > external aborts on omap5-uevm dwc3 controller. I have not been > able to bisect what exactly triggered this as it does not always > happen. It seems that something changed with probing tha

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Grygorii Strashko [161208 15:38]: > On 12/08/2016 04:57 PM, Tony Lindgren wrote: > > Seems to work based on few boot tests. Probably both should be applied, > > my original patch to prevent spurious interrupts before things are > > initialized, > > you patch - do you mean disable irq or clean

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Grygorii Strashko
On 12/08/2016 04:57 PM, Tony Lindgren wrote: * Grygorii Strashko [161208 13:54]: Hi Tony, On 12/08/2016 09:37 AM, Tony Lindgren wrote: * Felipe Balbi [161208 01:45]: Tony Lindgren writes: Somehow starting with v4.9-rc7 there have been imprecise There's nothing touching dwc3 since v4.9

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Grygorii Strashko [161208 13:54]: > Hi Tony, > > On 12/08/2016 09:37 AM, Tony Lindgren wrote: > > * Felipe Balbi [161208 01:45]: > >> Tony Lindgren writes: > >>> Somehow starting with v4.9-rc7 there have been imprecise > >> > >> There's nothing touching dwc3 since v4.9-rc5. > > > > Right, no

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Grygorii Strashko
Hi Tony, On 12/08/2016 09:37 AM, Tony Lindgren wrote: > * Felipe Balbi [161208 01:45]: >> Tony Lindgren writes: >>> Somehow starting with v4.9-rc7 there have been imprecise >> >> There's nothing touching dwc3 since v4.9-rc5. > > Right, nothing obvious has changed. I think it's just a slight tim

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 12:10]: > > Hi, > > Tony Lindgren writes: > >> nothing against it. Would be nice if TI could confirm this is needed and > >> check if other families might also need it. > > > > But as we currently are not using the WRAPRESET bit, the reset > > function is nop except for t

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 12:12]: > > Hi, > > Tony Lindgren writes: > > * Felipe Balbi [161208 11:17]: > >> Tony Lindgren writes: > >> > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. > >> > >> right, but there's no runtime suspend until ->remove(). IOW, after > >> pm_runti

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > * Felipe Balbi [161208 11:17]: >> Tony Lindgren writes: >> > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. >> >> right, but there's no runtime suspend until ->remove(). IOW, after >> pm_runtime_get_sync(), all necessary clocks should already b

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: >> nothing against it. Would be nice if TI could confirm this is needed and >> check if other families might also need it. > > But as we currently are not using the WRAPRESET bit, the reset > function is nop except for the delay. So this just papers over > the problem w

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 11:17]: > Tony Lindgren writes: > > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. > > right, but there's no runtime suspend until ->remove(). IOW, after > pm_runtime_get_sync(), all necessary clocks should already be > enabled. If they aren't, there's

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 11:19]: > > Hi, > > Tony Lindgren writes: > >> Is there also some dwc3 internal clock? If we assume the usb_otg_ss > >> module is properly enabled it could be some dwc3 internal clock not > >> enabled? > >> > >> We do have a srst_udelay needed for enabling musb controlle

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: >> Is there also some dwc3 internal clock? If we assume the usb_otg_ss >> module is properly enabled it could be some dwc3 internal clock not >> enabled? >> >> We do have a srst_udelay needed for enabling musb controller for some >> SoCs, I'll check if that's the case

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > * Felipe Balbi [161208 09:52]: >> >> Hi, >> >> Tony Lindgren writes: >> > * Felipe Balbi [161208 01:45]: >> >> >> >> Hi, >> >> >> >> Tony Lindgren writes: >> >> > Somehow starting with v4.9-rc7 there have been imprecise >> >> >> >> There's nothing touching dw

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Tony Lindgren [161208 10:45]: > * Tony Lindgren [161208 10:25]: > > * Felipe Balbi [161208 09:52]: > > > > > > Hi, > > > > > > Tony Lindgren writes: > > > > * Felipe Balbi [161208 01:45]: > > > >> > > > >> Hi, > > > >> > > > >> Tony Lindgren writes: > > > >> > Somehow starting with v4.9

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Tony Lindgren [161208 10:25]: > * Felipe Balbi [161208 09:52]: > > > > Hi, > > > > Tony Lindgren writes: > > > * Felipe Balbi [161208 01:45]: > > >> > > >> Hi, > > >> > > >> Tony Lindgren writes: > > >> > Somehow starting with v4.9-rc7 there have been imprecise > > >> > > >> There's not

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 09:52]: > > Hi, > > Tony Lindgren writes: > > * Felipe Balbi [161208 01:45]: > >> > >> Hi, > >> > >> Tony Lindgren writes: > >> > Somehow starting with v4.9-rc7 there have been imprecise > >> > >> There's nothing touching dwc3 since v4.9-rc5. > > > > Right, nothing o

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > * Felipe Balbi [161208 01:45]: >> >> Hi, >> >> Tony Lindgren writes: >> > Somehow starting with v4.9-rc7 there have been imprecise >> >> There's nothing touching dwc3 since v4.9-rc5. > > Right, nothing obvious has changed. I think it's just a slight timing > chan

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 01:45]: > > Hi, > > Tony Lindgren writes: > > Somehow starting with v4.9-rc7 there have been imprecise > > There's nothing touching dwc3 since v4.9-rc5. Right, nothing obvious has changed. I think it's just a slight timing change in the code that started triggering it.

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > Somehow starting with v4.9-rc7 there have been imprecise There's nothing touching dwc3 since v4.9-rc5. > external aborts on omap5-uevm dwc3 controller. I have not been > able to bisect what exactly triggered this as it does not always > happen. It seems that somethi