Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit

2013-05-29 Thread Huang Rui
On Thu, May 30, 2013 at 01:40:39AM +0800, Felipe Balbi wrote: > Hi, > > On Wed, May 29, 2013 at 02:05:43PM +0800, Huang Rui wrote: > > Hi Felipe, > > > > On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: > > > On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: > > > > This bit

Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit

2013-05-29 Thread Felipe Balbi
Hi, On Wed, May 29, 2013 at 02:05:43PM +0800, Huang Rui wrote: > Hi Felipe, > > On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: > > On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: > > > This bit is removed and set as reserved in 2.50a spec. > > > > > > Signed-off-by: Hua

Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit

2013-05-28 Thread Huang Rui
Hi Felipe, On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: > On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: > > This bit is removed and set as reserved in 2.50a spec. > > > > Signed-off-by: Huang Rui > > so ? This driver also works on older versions of the core. What y

Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit

2013-05-28 Thread Felipe Balbi
On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: > This bit is removed and set as reserved in 2.50a spec. > > Signed-off-by: Huang Rui so ? This driver also works on older versions of the core. What you should do is, perhaps, add a comment saying that this bit shouldn't be used in v2.5