Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-06-03 Thread Michael Grzeschik
Hi Felipe, On Thu, May 30, 2013 at 03:31:21PM -0500, Ruchika Kharwar wrote: > This patch adds an optional parameter "dr_mode" to the dwc3 core device node. > In the case the compile flag for the DWC3 controller is set to > "USB_DWC3_DUAL_ROLE" a device tree could restrain to either functionality o

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-31 Thread Michael Grzeschik
Hi, On Thu, May 30, 2013 at 03:14:54PM -0500, Ruchika Kharwar wrote: > This patch adds an optional parameter "dr_mode" to the dwc3 core device node. > In the case the compile flag for the DWC3 controller is set to > "USB_DWC3_DUAL_ROLE" a device tree could restrain to either functionality of > hos

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Felipe Balbi
Hi, On Thu, May 30, 2013 at 02:53:10PM -0500, Dan Murphy wrote: > > @@ -520,9 +520,23 @@ static int dwc3_probe(struct platform_device *pdev) > > mode = DWC3_MODE_HOST; > > else if (IS_ENABLED(CONFIG_USB_DWC3_GADGET)) > > mode = DWC3_MODE_DEVICE; > > - else > > -

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Ruchika Kharwar
On 05/30/2013 03:35 PM, Dan Murphy wrote: Fix spelling in my own comments On 05/30/2013 03:31 PM, Dan Murphy wrote: On 05/30/2013 03:14 PM, Ruchika Kharwar wrote: This patch adds an optional parameter "dr_mode" to the dwc3 core device node. In the case the compile flag for the DWC3 controller

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Dan Murphy
Fix spelling in my own comments On 05/30/2013 03:31 PM, Dan Murphy wrote: > On 05/30/2013 03:14 PM, Ruchika Kharwar wrote: >> This patch adds an optional parameter "dr_mode" to the dwc3 core device node. >> In the case the compile flag for the DWC3 controller is set to >> "USB_DWC3_DUAL_ROLE" a de

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Sergei Shtylyov
Hello. On 05/31/2013 12:14 AM, Ruchika Kharwar wrote: This patch adds an optional parameter "dr_mode" to the dwc3 core device node. In the case the compile flag for the DWC3 controller is set to "USB_DWC3_DUAL_ROLE" a device tree could restrain to either functionality of host or gadget. In the

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Dan Murphy
On 05/30/2013 12:56 PM, Ruchika Kharwar wrote: > This patch adds the possibility of the "mode" being specified in a device > tree. This allows the scenario when there maybe multiple USB subsystems > operating in different modes. Nitpick. Maybes and possibilities can we get more concrete statements