Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-23 Thread Minas Harutyunyan
Hi John, On 12/21/2018 8:05 PM, John Keeping wrote: > Hi Minas, > > On Wed, 19 Dec 2018 14:09:01 + > Minas Harutyunyan wrote: > >> On 12/18/2018 6:35 PM, John Keeping wrote: >>> Hi Minas, >>> >>> On Fri, 14 Dec 2018 09:00:08 + >>> Minas Harutyunyan wrote: First of all, sorry for d

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-21 Thread John Keeping
Hi Minas, On Wed, 19 Dec 2018 14:09:01 + Minas Harutyunyan wrote: > On 12/18/2018 6:35 PM, John Keeping wrote: > > Hi Minas, > > > > On Fri, 14 Dec 2018 09:00:08 + > > Minas Harutyunyan wrote: > >> First of all, sorry for delayed answer. > >> Looks like similar issue seen by Andrzej

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-19 Thread Minas Harutyunyan
Hi John, On 12/18/2018 6:35 PM, John Keeping wrote: > Hi Minas, > > On Fri, 14 Dec 2018 09:00:08 + > Minas Harutyunyan wrote: >> First of all, sorry for delayed answer. >> Looks like similar issue seen by Andrzej Pietrasiewicz >> : "dwc2 isochronous transfers issues". Same >> feedback provid

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-18 Thread John Keeping
Hi Minas, On Fri, 14 Dec 2018 09:00:08 + Minas Harutyunyan wrote: > First of all, sorry for delayed answer. > Looks like similar issue seen by Andrzej Pietrasiewicz > : "dwc2 isochronous transfers issues". Same > feedback provided to Andrzej. > > I run tests on 4.20.0-rc4 in DDMA. By defau

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-14 Thread Minas Harutyunyan
Hi John, On 11/13/2018 2:46 AM, John Keeping wrote: > Hi Minas, > > On Mon, 12 Nov 2018 08:53:36 + > Minas Harutyunyan wrote: >> On 11/9/2018 10:43 PM, John Keeping wrote: >>> On Fri, 9 Nov 2018 14:36:36 + >>> Minas Harutyunyan wrote: >>> On 11/9/2018 12:43 PM, Minas Harutyunya

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-12 Thread John Keeping
Hi Minas, On Mon, 12 Nov 2018 08:53:36 + Minas Harutyunyan wrote: > On 11/9/2018 10:43 PM, John Keeping wrote: > > On Fri, 9 Nov 2018 14:36:36 + > > Minas Harutyunyan wrote: > > > >> On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: > >>> Hi John, > >>> > >>> On 11/8/2018 9:37 PM, Joh

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-12 Thread Minas Harutyunyan
Hi John, On 11/9/2018 10:43 PM, John Keeping wrote: > Hi Minas, > > On Fri, 9 Nov 2018 14:36:36 + > Minas Harutyunyan wrote: > >> On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: >>> Hi John, >>> >>> On 11/8/2018 9:37 PM, John Keeping wrote: Hi Minas, On Mon, 5 Nov 2018 08:28:

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-09 Thread John Keeping
Hi Minas, On Fri, 9 Nov 2018 14:36:36 + Minas Harutyunyan wrote: > On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: > > Hi John, > > > > On 11/8/2018 9:37 PM, John Keeping wrote: > >> Hi Minas, > >> > >> On Mon, 5 Nov 2018 08:28:07 + > >> Minas Harutyunyan wrote: > >> > >>> On 10/23/201

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-09 Thread Minas Harutyunyan
Hi John, On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: > Hi John, > > On 11/8/2018 9:37 PM, John Keeping wrote: >> Hi Minas, >> >> On Mon, 5 Nov 2018 08:28:07 + >> Minas Harutyunyan wrote: >> >>> On 10/23/2018 5:43 PM, John Keeping wrote: By clearing the overrun flag as soon as the ta

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-09 Thread Minas Harutyunyan
Hi John, On 11/8/2018 9:37 PM, John Keeping wrote: > Hi Minas, > > On Mon, 5 Nov 2018 08:28:07 + > Minas Harutyunyan wrote: > >> On 10/23/2018 5:43 PM, John Keeping wrote: >>> By clearing the overrun flag as soon as the target frame is next >>> incremented, we can end up incrementing the ta

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-08 Thread John Keeping
Hi Minas, On Mon, 5 Nov 2018 08:28:07 + Minas Harutyunyan wrote: > On 10/23/2018 5:43 PM, John Keeping wrote: > > By clearing the overrun flag as soon as the target frame is next > > incremented, we can end up incrementing the target frame more than > > expected in dwc2_gadget_handle_ep_disa

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-11-05 Thread Minas Harutyunyan
Hi John, On 10/23/2018 5:43 PM, John Keeping wrote: > By clearing the overrun flag as soon as the target frame is next > incremented, we can end up incrementing the target frame more than > expected in dwc2_gadget_handle_ep_disabled() when the endpoint's > interval is greater than 1. This happens