Re: [PATCH] usb: cdc_acm: Do not leak URB buffers

2018-09-24 Thread Oliver Neukum
On Mo, 2018-09-24 at 10:20 +0200, Romain Izard wrote: > 2018-09-21 15:27 +0200, Oliver Neukum : > > > > On Do, 2018-09-20 at 16:49 +0200, Romain Izard wrote: > > > When the ACM TTY port is disconnected, the URBs it uses must be killed, > > > and then the buffers must be freed. Unfortunately a prev

Re: [PATCH] usb: cdc_acm: Do not leak URB buffers

2018-09-24 Thread Oliver Neukum
On Do, 2018-09-20 at 16:49 +0200, Romain Izard wrote: > When the ACM TTY port is disconnected, the URBs it uses must be killed, and > then the buffers must be freed. Unfortunately a previous refactor removed > the code freeing the buffers because it looked extremely similar to the > code killing th

Re: [PATCH] usb: cdc_acm: Do not leak URB buffers

2018-09-24 Thread Romain Izard
2018-09-21 15:27 +0200, Oliver Neukum : > > On Do, 2018-09-20 at 16:49 +0200, Romain Izard wrote: > > When the ACM TTY port is disconnected, the URBs it uses must be killed, > > and then the buffers must be freed. Unfortunately a previous refactor > > removed the code freeing the buffers because it

Re: [PATCH] usb: cdc_acm: Do not leak URB buffers

2018-09-21 Thread Oliver Neukum
On Do, 2018-09-20 at 16:49 +0200, Romain Izard wrote: > When the ACM TTY port is disconnected, the URBs it uses must be killed, and > then the buffers must be freed. Unfortunately a previous refactor removed > the code freeing the buffers because it looked extremely similar to the > code killing th