RE: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-10 Thread Alan Stern
On Fri, 10 Jan 2014, Venkatesh Murthy, HemanthX wrote: > Yes agree, but I think the multiple loops can be avoided. With the > below change in hub_port_wait_reset around 5 secs is saved for > disconnect detection. > > @@ -2545,15 +2546,15 @@ static int hub_port_wait_reset(struct usb_hub *hub, > i

RE: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-10 Thread Venkatesh Murthy, HemanthX
>-Original Message- >From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] >Sent: Friday, January 10, 2014 12:44 AM >To: Venkatesh Murthy, HemanthX >Cc: Alan Stern; linux-usb@vger.kernel.org; Nandibasappa, GirishX >Subject: Re: [PATCH] usb: Skip U1/U2 LPM di

Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-09 Thread Sarah Sharp
On Wed, Jan 08, 2014 at 09:20:41AM +, Venkatesh Murthy, HemanthX wrote: > We tried pulling this commit to our tree, we still see below errors multiple > times. That's expected. The device disconnect causes the port to go into the Inactive state and the host *must* handle that. > Should hub_

RE: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-08 Thread Venkatesh Murthy, HemanthX
>-Original Message- >From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] >Sent: Tuesday, January 07, 2014 12:16 AM >To: Alan Stern >Cc: linux-usb@vger.kernel.org; Nandibasappa, GirishX; Venkatesh Murthy, >HemanthX >Subject: Re: [PATCH] usb: Skip U1/U2 LPM

Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-06 Thread Sarah Sharp
On Sat, Jan 04, 2014 at 12:09:27PM -0500, Alan Stern wrote: > On Fri, 3 Jan 2014, Sarah Sharp wrote: > > > Occasionally when a USB 3.0 device is disconnected, the roothub port > > goes into the SS.Inactive state, rather than reporting a disconnect. A > > warm reset is the only way to get out of t

Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-06 Thread Sarah Sharp
On Fri, Jan 03, 2014 at 04:49:16PM -0800, Greg KH wrote: > On Fri, Jan 03, 2014 at 04:22:45PM -0800, Sarah Sharp wrote: > > Occasionally when a USB 3.0 device is disconnected, the roothub port > > goes into the SS.Inactive state, rather than reporting a disconnect. > > Is that a hardware bug? Or

Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-04 Thread Alan Stern
On Fri, 3 Jan 2014, Sarah Sharp wrote: > Occasionally when a USB 3.0 device is disconnected, the roothub port > goes into the SS.Inactive state, rather than reporting a disconnect. A > warm reset is the only way to get out of this state. khubd notices the > link state in hub_port_events(), Do y

Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-03 Thread Greg KH
On Fri, Jan 03, 2014 at 04:22:45PM -0800, Sarah Sharp wrote: > Occasionally when a USB 3.0 device is disconnected, the roothub port > goes into the SS.Inactive state, rather than reporting a disconnect. Is that a hardware bug? Or just something inherent in how the spec says things can work? than