Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-13 Thread Arnd Bergmann
On Tuesday, September 13, 2016 4:50:05 PM CEST Peter Chen wrote: > On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote: > > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > > > > > I just see below Kconfig entry at the same Kconfig > > > (drivers/usb/Kconfig), and for

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-13 Thread Peter Chen
On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote: > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > > > I just see below Kconfig entry at the same Kconfig > > (drivers/usb/Kconfig), and forget your changes. > > > > config USB_LED_TRIG > > bool "USB LED Tr

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-13 Thread Arnd Bergmann
On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > I just see below Kconfig entry at the same Kconfig > (drivers/usb/Kconfig), and forget your changes. > > config USB_LED_TRIG > bool "USB LED Triggers" > depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS >

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-13 Thread Peter Chen
On Tue, Sep 13, 2016 at 09:04:08AM +0200, Arnd Bergmann wrote: > On Tuesday, September 13, 2016 9:48:55 AM CEST Peter Chen wrote: > > On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote: > > > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file > > > means that we can enab

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-13 Thread Arnd Bergmann
On Tuesday, September 13, 2016 9:48:55 AM CEST Peter Chen wrote: > On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote: > > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file > > means that we can enable it without any of the other USB support, > > leading to a build erro

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-12 Thread Peter Chen
On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote: > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file > means that we can enable it without any of the other USB support, > leading to a build error because Kbuild never enters the > drivers/usb/common/ directory without