Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-14 Thread Johan Hovold
On Fri, Sep 14, 2018 at 09:53:31AM +0200, Kristian Evensen wrote: > Hi Johan, > On Fri, Sep 14, 2018 at 9:51 AM Johan Hovold wrote: > > Great, thanks for testing. Do you mind if I add your tested-by to the > > patch? > > Not at all, go right ahead! I should probably have replied to the > patch wi

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-14 Thread Kristian Evensen
Hi Johan, On Fri, Sep 14, 2018 at 9:51 AM Johan Hovold wrote: > Great, thanks for testing. Do you mind if I add your tested-by to the > patch? Not at all, go right ahead! I should probably have replied to the patch with a Tested-by. Sorry about forgetting that. BR, Kristian

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-14 Thread Johan Hovold
On Thu, Sep 13, 2018 at 05:13:02PM +0200, Kristian Evensen wrote: > I just finished backporting + testing your patch with our 4.14-kernel > (mine is already there) and it works great. The driver correctly > handles different EP06-configurations. Great, thanks for testing. Do you mind if I add you

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-13 Thread Kristian Evensen
Hello again, On Thu, Sep 13, 2018 at 11:17 AM Johan Hovold wrote: > Kristian would you mind giving it a try? I just finished backporting + testing your patch with our 4.14-kernel (mine is already there) and it works great. The driver correctly handles different EP06-configurations. Thanks a lot

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-13 Thread Kristian Evensen
Hi Johan, On Thu, Sep 13, 2018 at 11:17 AM Johan Hovold wrote: > Kristian would you mind giving it a try? Yes, thank you very much. I will give the patches a go during the day today and report back. > Oh, also note that I dropped the RSVD(5) for the ADB interface in your > patch since it uses a

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-13 Thread Johan Hovold
On Wed, Sep 12, 2018 at 10:34:43PM +0200, Bjørn Mork wrote: > Dan Williams writes: > > > The fact that the firmware implementation has the ability to change the > > endpoints is unrelated to Kristian's case, and that alone is > > justification for this to be quirked in the driver. People other t

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-12 Thread Bjørn Mork
Dan Williams writes: > The fact that the firmware implementation has the ability to change the > endpoints is unrelated to Kristian's case, and that alone is > justification for this to be quirked in the driver. People other than > Kristian will undoubtedly use the functionality, on platforms le

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-12 Thread Dan Williams
On Thu, 2018-09-13 at 01:25 +0700, Lars Melin wrote: > On 9/12/2018 23:57, Kristian Evensen wrote: > > On Wed, Sep 12, 2018 at 6:32 PM Lars Melin > > wrote: > > > You have chosen a platform which has limited usb resources and > > > want to > > > solve that problem by adjusting the device driver? >

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-12 Thread Lars Melin
On 9/12/2018 23:57, Kristian Evensen wrote: On Wed, Sep 12, 2018 at 6:32 PM Lars Melin wrote: You have chosen a platform which has limited usb resources and want to solve that problem by adjusting the device driver? No, you asked for a good reason for why disabling and not just ignoring an in

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-12 Thread Kristian Evensen
On Wed, Sep 12, 2018 at 6:32 PM Lars Melin wrote: > You have chosen a platform which has limited usb resources and want to > solve that problem by adjusting the device driver? No, you asked for a good reason for why disabling and not just ignoring an interface makes sense, and I think that suppor

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-12 Thread Lars Melin
On 9/11/2018 21:34, Kristian Evensen wrote: On Tue, Sep 11, 2018 at 4:00 PM Lars Melin wrote: My opinion is that the option and qmi-wwan drivers should support EP06 in the factory delivery configuration and not in a configuration the user has selected with a Quectel proprietary AT cmd. Can yo

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-11 Thread Kristian Evensen
On Tue, Sep 11, 2018 at 4:00 PM Lars Melin wrote: > This also becomes a mess for the qmi-wwan driver which has the rmnet/qmi > interface hardcoded to 4 so that driver will also need a workaround. > Quectel seems to have completely missed the reason why usb id's should > be unique and not reused f

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-11 Thread Lars Melin
On 9/10/2018 18:39, Kristian Evensen wrote: Hi, On Mon, Sep 10, 2018 at 12:30 PM Johan Hovold wrote: Please provide the output of usb-devices (or lsusb -v) for both "configurations". How do you update the configuration by the way? The configuration is updated using a proprietary AT-command (

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Dan Williams
On Sat, 2018-09-08 at 14:57 +0200, Kristian Evensen wrote: > The Quectel EP06 (and EM06/EG06) LTE modem supports updating the USB > configuration, without the VID/PID or configuration number changing. > When the configuration is updated and interfaces are added/removed, > the > interface numbers ar

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Kristian Evensen
Hi, On Mon, Sep 10, 2018 at 12:30 PM Johan Hovold wrote: > Please provide the output of usb-devices (or lsusb -v) for both > "configurations". How do you update the configuration by the way? The configuration is updated using a proprietary AT-command (AT+QCFG="usbcfg"). The format of the command

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Johan Hovold
On Sat, Sep 08, 2018 at 02:57:54PM +0200, Kristian Evensen wrote: > The Quectel EP06 (and EM06/EG06) LTE modem supports updating the USB > configuration, without the VID/PID or configuration number changing. > When the configuration is updated and interfaces are added/removed, the > interface numbe