Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Alexander Holler
Am 11.04.2013 20:29, schrieb Felipe Balbi: > and who said OMAP USB depends on CONFIG_USB_PHY ? Some platforms need to > control a PHY and some don't. I've read that so. > Go check out kernel 2.6.39 (maybe even 3.1 and 3.2) and you'll see that > we're much better off today where we can actually h

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 07:33:32PM +0200, Alexander Holler wrote: > >>Sorry, but this just will end up with many users having broken configs > >>because of disabled stuff they don't know why they have to enable them. > >>And thus with a never ending stream of questions and thus with a needed >

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Alexander Holler
Am 11.04.2013 16:44, schrieb Roger Quadros: Sorry, but this just will end up with many users having broken configs because of disabled stuff they don't know why they have to enable them. And thus with a never ending stream of questions and thus with a needed FAQ entry. Alexander, I agree wit

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 05:53:10PM +0300, Roger Quadros wrote: > >>> From: Roger Quadros > >>> Date: Thu, 11 Apr 2013 12:08:19 +0300 > >>> Subject: [PATCH] USB: ehci-omap: Select USB_PHY > >>> > >>> As we need NOP_USB_XCEIV which depends on USB_PHY > >>> we need to sel

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 05:44:00PM +0300, Roger Quadros wrote: > Felipe, > > On 04/11/2013 04:02 PM, Alexander Holler wrote: > > Am 11.04.2013 14:42, schrieb Roger Quadros: > >> On 04/11/2013 01:55 PM, Felipe Balbi wrote: > > > >>> I would avoid 'select' completely and just update omap2plus_

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
On 04/11/2013 05:34 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 04:18:33PM +0300, Roger Quadros wrote: >> On 04/11/2013 03:42 PM, Roger Quadros wrote: >>> On 04/11/2013 01:55 PM, Felipe Balbi wrote: Hi, On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: >>>

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
Felipe, On 04/11/2013 04:02 PM, Alexander Holler wrote: > Am 11.04.2013 14:42, schrieb Roger Quadros: >> On 04/11/2013 01:55 PM, Felipe Balbi wrote: > >>> I would avoid 'select' completely and just update omap2plus_defconfig >>> adding those two as modules. Setting USB_PHY as a module gives rise

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 04:18:33PM +0300, Roger Quadros wrote: > On 04/11/2013 03:42 PM, Roger Quadros wrote: > > On 04/11/2013 01:55 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: > >>> On 04/11/2013 01:04 PM, Felipe Balbi wrote: > >>

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
On 04/11/2013 03:42 PM, Roger Quadros wrote: > On 04/11/2013 01:55 PM, Felipe Balbi wrote: >> Hi, >> >> On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: >>> On 04/11/2013 01:04 PM, Felipe Balbi wrote: Hi, On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: >>

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Alexander Holler
Am 11.04.2013 14:42, schrieb Roger Quadros: > On 04/11/2013 01:55 PM, Felipe Balbi wrote: >> I would avoid 'select' completely and just update omap2plus_defconfig >> adding those two as modules. >> > > OK, makes sense. I will update the patch to remove "select NOP_USB_XCEIV". Sorry, but this jus

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
On 04/11/2013 01:55 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: >> On 04/11/2013 01:04 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: Hi Greg, The following patch gets rid of

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: > On 04/11/2013 01:04 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: > >> Hi Greg, > >> > >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP > >> is en

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
On 04/11/2013 01:04 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: >> Hi Greg, >> >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP >> is enabled. >> >> Patch is based on your usb-next branch and is needed for 3.10. >> >> Fr

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: > Hi Greg, > > The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP > is enabled. > > Patch is based on your usb-next branch and is needed for 3.10. > > From: Roger Quadros > Date: Thu, 11 Apr 2013 12:08:19 +0