Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-27 Thread Adam Lee
On Tue, Jan 27, 2015 at 08:36:07PM +0100, Oliver Neukum wrote: > Hi, > > could you test and review this? $ git am ~/0001-cdc-acm-add-sanity-checks.patch Applying: cdc-acm: add sanity checks /home/adamlee/ubuntu-vivid/.git/rebase-apply/patch:26: trailing whitespace.

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-27 Thread Oliver Neukum
On Fri, 2015-01-23 at 23:08 +0800, Adam Lee wrote: Hi, could you test and review this? Regards Oliver >From 1ddabb5731135fe43f67f3b4645445c2de06dada Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Tue, 13 Jan 2015 16:55:52 +0100 Subject: [PATCH] cdc-acm: add sanity c

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-23 Thread Oliver Neukum
On Fri, 2015-01-23 at 23:02 +0800, Adam Lee wrote: > On Fri, Jan 23, 2015 at 09:44:38AM +0100, Oliver Neukum wrote: > > On Fri, 2015-01-23 at 14:54 +0800, Adam Lee wrote: > > > In my scenario(pull that device then plug into another usb port while > > > booting), invalid descriptor accessing happens

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-23 Thread Adam Lee
On Fri, Jan 23, 2015 at 11:02:19PM +0800, Adam Lee wrote: > On Fri, Jan 23, 2015 at 09:44:38AM +0100, Oliver Neukum wrote: > > On Fri, 2015-01-23 at 14:54 +0800, Adam Lee wrote: > > > In my scenario(pull that device then plug into another usb port while > > > booting), invalid descriptor accessing

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-23 Thread Adam Lee
On Fri, Jan 23, 2015 at 09:44:38AM +0100, Oliver Neukum wrote: > On Fri, 2015-01-23 at 14:54 +0800, Adam Lee wrote: > > In my scenario(pull that device then plug into another usb port while > > booting), invalid descriptor accessing happens just like Simon reported. > > Checking length and ignoring

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-23 Thread Oliver Neukum
On Fri, 2015-01-23 at 14:54 +0800, Adam Lee wrote: > In my scenario(pull that device then plug into another usb port while > booting), invalid descriptor accessing happens just like Simon reported. > Checking length and ignoring the invalid descriptors works. Hi, interesting. Have a look at what