Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-24 Thread Philippe Ombredanne
Rob: On Sat, Oct 21, 2017 at 9:48 AM, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 10:26:22AM -0500, Rob Herring wrote: >> On Thu, Oct 19, 2017 at 3:38 AM, Greg Kroah-Hartman >> wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the kernel tree for

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-21 Thread Greg Kroah-Hartman
On Fri, Oct 20, 2017 at 10:26:22AM -0500, Rob Herring wrote: > On Thu, Oct 19, 2017 at 3:38 AM, Greg Kroah-Hartman > wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files i

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-21 Thread Greg Kroah-Hartman
On Fri, Oct 20, 2017 at 06:49:30PM +0100, Alan Cox wrote: > > But all that matters is the tag is there for tools to be able to extract > > it properly. And if we have that, it doesn't matter what the comment > > "style" would be, so might as well make it look "nicer". > > > > And, to take it to t

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-20 Thread Alan Cox
> But all that matters is the tag is there for tools to be able to extract > it properly. And if we have that, it doesn't matter what the comment > "style" would be, so might as well make it look "nicer". > > And, to take it to the next conclusion, if we have the SPDX identifier, > we can get rid

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-20 Thread Rob Herring
On Thu, Oct 19, 2017 at 3:38 AM, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. This patch adds these > identifiers to all files in drivers/usb/ based on a script and data from > Thomas Gleixner, Phili

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Philippe Ombredanne
On Thu, Oct 19, 2017 at 11:10 AM, Greg Kroah-Hartman wrote: > And, to take it to the next conclusion, if we have the SPDX identifier, > we can get rid of the "boilerplate" GPL license crap as well, right? > > How about this example patch of just 2 files, we could drop so many > lines that we are

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: >> Hi Greg, >> >> On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman >> wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the kernel tree for correct

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Thomas Gleixner
On Thu, 19 Oct 2017, Geert Uytterhoeven wrote: > On Thu, Oct 19, 2017 at 10:52 AM, Greg Kroah-Hartman > wrote: > > On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: > >> On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman > >> wrote: > >> > It's good to have SPDX identifiers in

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 11:01:56AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > > > The last discussion about this was to add the identifier as the first line > > > of the file or as the second

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Geert Uytterhoeven
Hi Greg, On Thu, Oct 19, 2017 at 10:52 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: >> On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman >> wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the ke

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Thomas Gleixner
On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > > The last discussion about this was to add the identifier as the first line > > of the file or as the second in case of files with a shebang in the first > > one. > > > > I think yo

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files in driver

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files in driver

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Thomas Gleixner
On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. This patch adds these > identifiers to all files in drivers/usb/ based on a script and data from > Thomas Gleixner, Philippe Ombredan

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman > wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > iden

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Geert Uytterhoeven
Hi Greg, On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. This patch adds these > identifiers to all files in drivers/usb/ based on a script and data from > Thomas Glei