Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-18 Thread Dan Williams
On Thu, 2013-01-17 at 14:44 +0800, Wei Shuai wrote: > OK, I will follow up. after add FLAG_NOARP, how should I handle > IFF_NOARP? will I do it in cdc_ncm.c or usb_net.c? usbnet.c Dan > 2013/1/17 Dan Williams : > > On Sat, 2013-01-12 at 19:34 +0800, Wei Shuai wrote: > >> Infineon(now Intel) HSPA

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-16 Thread Wei Shuai
OK, I will follow up. after add FLAG_NOARP, how should I handle IFF_NOARP? will I do it in cdc_ncm.c or usb_net.c? 2013/1/17 Dan Williams : > On Sat, 2013-01-12 at 19:34 +0800, Wei Shuai wrote: >> Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I >> introduce a flag CDC_NCM_DRI

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-16 Thread Dan Williams
On Sat, 2013-01-12 at 19:34 +0800, Wei Shuai wrote: > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I > introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in > driver_info:data. so later on, if more such buggy devices are found, they > could use same flag to handle.

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-16 Thread David Miller
From: Bjørn Mork Date: Tue, 15 Jan 2013 09:34:07 +0100 > The main problem is that these devices don't support ethernet. They > support IP (v4 and _maybe_ v6) with an ethernet header. Many of them > will do ARP (and IPv6 ND) as well to complete the picture, but some of > them don't and that's wh

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-15 Thread Wei Shuai
yes. usbnet has FLAG_POINTTOPOINT, but that's nothing to do with IFF_POINTTOPOINT. At least we should do something to handle relationship of these flags rather than only have different names. or new flag FLAG_NOARP could be introduced to corresponding to IFF_NOARP. 2013/1/15 Dan Williams : > On Sa

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-15 Thread Bjørn Mork
David Miller writes: > From: Dan Williams > >> IFF_NOARP is already done for other WWAN devices (sierra_net, hso, >> cdc-ether, cdc-phonet, lg-vl600, etc) so there is some precedent. Some >> drivers (phonet, hso) set *both* POINTTOPOINT and NOARP. Is that >> redundant, and should all WWAN driv

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread Peter Stuge
David Miller wrote: > > should all WWAN drivers be moved to only POINTTOPOINT? > > I can't answer any of your questions unless you tell me what the > real limitation of these devices is. It's rather about the network than any given devices, right? //Peter -- To unsubscribe from this list: send

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread David Miller
From: Dan Williams Date: Mon, 14 Jan 2013 11:19:13 -0600 > On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: >> From: Wei Shuai >> Date: Sat, 12 Jan 2013 19:34:39 +0800 >> >> > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I >> > introduce a flag CDC_NCM_DRIVER_DATA_NO

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread Dan Williams
On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: > From: Wei Shuai > Date: Sat, 12 Jan 2013 19:34:39 +0800 > > > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I > > introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in > > driver_info:data. so later on, if more

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-12 Thread David Miller
From: Wei Shuai Date: Sat, 12 Jan 2013 19:34:39 +0800 > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I > introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in > driver_info:data. so later on, if more such buggy devices are found, > they could use same flag to handle