Re: xhci ASMedia lockups - a theory and a patch

2014-01-21 Thread Sarah Sharp
On Tue, Jan 21, 2014 at 10:00:40AM +, David Laight wrote: > From: Sarah Sharp [ > > On Thu, Jan 16, 2014 at 10:21:11AM +, David Laight wrote: > > > From: David Laight > > > > From: David Laight > ... > > > > Below is a possible patch, I've only compile tested it. > > > > I've minimalised t

RE: xhci ASMedia lockups - a theory and a patch

2014-01-21 Thread David Laight
From: Sarah Sharp [ > On Thu, Jan 16, 2014 at 10:21:11AM +, David Laight wrote: > > From: David Laight > > > From: David Laight ... > > > Below is a possible patch, I've only compile tested it. > > > I've minimalised the patch by not removing all the code that saves > > > 'start_trb' and modif

Re: xhci ASMedia lockups - a theory and a patch

2014-01-20 Thread Sarah Sharp
On Thu, Jan 16, 2014 at 10:21:11AM +, David Laight wrote: > From: David Laight > > From: David Laight > > > From: Alan Stern > > > > On Wed, 15 Jan 2014, David Laight wrote: > > > > > > > > > I have a theory, I'll try to write a non-invasive patch. > > ... > > > > > > > > Doesn't this mean you

RE: xhci ASMedia lockups - a theory and a patch

2014-01-16 Thread David Laight
From: David Laight > From: David Laight > > From: Alan Stern > > > On Wed, 15 Jan 2014, David Laight wrote: > > > > > > > I have a theory, I'll try to write a non-invasive patch. > ... > > > > > > Doesn't this mean you shouldn't change the ownership of a LINK TRB > > > until after you change the ow

RE: xhci ASMedia lockups - a theory and a patch

2014-01-15 Thread David Laight
From: David Laight > From: Alan Stern > > On Wed, 15 Jan 2014, David Laight wrote: > > > > > I have a theory, I'll try to write a non-invasive patch. ... > > > > Doesn't this mean you shouldn't change the ownership of a LINK TRB > > until after you change the ownership of the TRB it points to? > >

RE: xhci ASMedia lockups - a theory

2014-01-15 Thread David Laight
From: Alan Stern > On Wed, 15 Jan 2014, David Laight wrote: > > > I have a theory, I'll try to write a non-invasive patch. > > > > In spite of the comments and some code paths inc_enq() is only > > called by (and has only ever been called by) queue_trb(), so > > is only called for transfer and co

Re: xhci ASMedia lockups - a theory

2014-01-15 Thread Alan Stern
On Wed, 15 Jan 2014, David Laight wrote: > I have a theory, I'll try to write a non-invasive patch. > > In spite of the comments and some code paths inc_enq() is only > called by (and has only ever been called by) queue_trb(), so > is only called for transfer and command rings. > > It takes care