Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-27 Thread Sebastian Andrzej Siewior
On 11/27/2012 10:19 AM, Andrzej Pietrasiewicz wrote: ALIAS() to have a string which can be referred to in adapters, which provide the old modprobe + parameters (+ e.g. sysfs) interface and should be able to request_module("usb_functions"); The string could be defined in some header file include

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-27 Thread Sebastian Andrzej Siewior
On 11/26/2012 07:46 PM, Alan Stern wrote: On Mon, 26 Nov 2012, Michal Nazarewicz wrote: On Mon, Nov 26 2012, Alan Stern wrote: In your example, what files would appear under under /functions/storage? I gather that the "storage" part is just a placeholder name with no real meaning. The meanin

RE: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-27 Thread Andrzej Pietrasiewicz
On Monday, November 26, 2012 5:51 PM Sebastian Andrzej Siewior wrote: > On 11/23/2012 12:52 PM, Andrzej Pietrasiewicz wrote: > >>> +static struct config_group *ufg_make_function_subgroup( > >>> + struct config_group *group, const char *name) { > >>> + struct ufg_function_grp *f_grp; > >>> + stru

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Michal Nazarewicz wrote: > On Mon, Nov 26 2012, Alan Stern wrote: > > In your example, what files would appear under under > > /functions/storage? I gather that the "storage" part is just a > > placeholder name with no real meaning. The meaning is conveyed > > when the user

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Michal Nazarewicz
On Mon, Nov 26 2012, Alan Stern wrote: > In your example, what files would appear under under > /functions/storage? I gather that the "storage" part is just a > placeholder name with no real meaning. The meaning is conveyed > when the user writes "mass_storage" to /functions/storage/name. > > Whe

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: > On 11/26/2012 05:57 PM, Alan Stern wrote: > > On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: > > > >> Step two is a folder where we setup individual configuration of a function. > >> > >> /functions/ttyS0 > >> /functions/ttyS1 > >> /fu

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Michal Nazarewicz
> On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: >> Step two is a folder where we setup individual configuration of a function. >> >> /functions/ttyS0 >> /functions/ttyS1 >> /functions/storage >> >> each one of the function folder has the file called "name". So for the >> folder ttyS0 the

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/26/2012 05:57 PM, Alan Stern wrote: On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: Step two is a folder where we setup individual configuration of a function. /functions/ttyS0 /functions/ttyS1 /functions/storage each one of the function folder has the file called "name". So for t

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: > Step two is a folder where we setup individual configuration of a function. > > /functions/ttyS0 > /functions/ttyS1 > /functions/storage > > each one of the function folder has the file called "name". So for the > folder ttyS0 the file name

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/23/2012 12:52 PM, Andrzej Pietrasiewicz wrote: The general idea is that: echo "some_name"> /cfg/usb-function-gadget/G1/C1/F1/name echo "some_name"> /cfg/usb-function-gadget/G1/C2/F1/name creates two separate instances of F1 in C1 and C2. Did you mean the same instance of F1 used both in

configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/22/2012 09:59 PM, Michal Nazarewicz wrote: echo MassStorage> /cfg/usb-function-gadget/G1/C1/F1/name Why not mkdir /cfg/usb-function-gadget/G1/C1/F1/MassStorage ? Let me add what I have in my head + what Michał said in other mail: Lets assume we start at /sys/kernel/config/ga

RE: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-23 Thread Andrzej Pietrasiewicz
Hello Michał, Thanks for comments, I generally agree. On Thursday, November 22, 2012 10:00 PM Michal Nazarewicz wrote: > > > > Then specific functions to be run follow, e.g.: > > > > echo MassStorage > /cfg/usb-function-gadget/G1/C1/F1/name > > Why not > > mkdir /cfg/usb-function-gadge

RE: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-23 Thread Andrzej Pietrasiewicz
Hello Michał, I generally agree. Specifically, please see inline. On Thursday, November 22, 2012 9:25 PM Michal Nazarewicz wrote: > On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote: > > One thing you miss: Lets say you have C1 and C2. How do you configure > > the same F1 in C1 and C2 _and

RE: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-23 Thread Andrzej Pietrasiewicz
Hello Sebastian, As far as many of your comments are concerned, I agree and do not reply to them. For others I agree and reply, and for yet others I reply ;) Please see inline. On Thursday, November 22, 2012 5:57 PM Sebastian Andrzej Siewior wrote: > * Andrzej Pietrasiewicz | 2012-11-22 13:06:56

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-23 Thread Sebastian Andrzej Siewior
On 11/22/2012 09:25 PM, Michal Nazarewicz wrote: echo 1> /cfg/usb-function-gadget/G1/ready On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote: One thing you miss: Lets say you have C1 and C2. How do you configure the same F1 in C1 and C2 _and_ how do you configure a different F1 in F1 and F

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > mount -t configfs none /cfg > mkdir -p /cfg/usb-function-gadget/G1/C1/F1 > echo 0x > /cfg/usb-function-gadget/G1/idVendor > echo 0x > /cfg/usb-function-gadget/G1/idProduct > echo 0x > /cfg/usb-function-gadget/G1/bcdDevice > echo > /cfg/usb-functi

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Michal Nazarewicz
> * Andrzej Pietrasiewicz | 2012-11-22 13:06:56 [+0100]: >> echo .img > >> /cfg/usb-function-gadget/G1/C1/F1/MassStorage/lun0/file >> >> Do the similar thing to other functions, then >> >> echo 1 > /cfg/usb-function-gadget/G1/ready On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote: > One thing

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-11-22 13:06:56 [+0100]: >insmod libcomposite.ko >insmod g_usb_functions.ko You should use modprobe. Atleast g_usb_functions should pull in libcomposite if requried. >echo .img > /cfg/usb-function-gadget/G1/C1/F1/MassStorage/lun0/file > >Do the similar thing to othe