RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-06 Thread Pawel Laszczak
Hi, >>> > + >>> > +static inline void cdns3_role_stop(struct cdns3 *cdns) >>> > +{ >>> > + enum cdns3_roles role = cdns->role; >>> > + >>> > + if (role == CDNS3_ROLE_END) >>> >>> WARN_ON(role >= CNDS3_ROLE_END) ? >>> >>> > + return; >>> > + >>> > + mutex_lock(&cdns->mutex);

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-06 Thread Pawel Laszczak
Hi, >On 04/12/18 10:50, Peter Chen wrote: + * Cadence USBSS DRD Driver. + * + * Copyright (C) 2018 Cadence. + * + * Author: Peter Chen + * Pawel Laszczak + */ + +#include +#include +#include +#include +#include +#

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Pawel Laszczak
> >> Hi Roger >> >> >On 18/11/18 12:09, Pawel Laszczak wrote: >> >> Patch adds core.c and core.h file that implements initialization >> >> of platform driver and adds function responsible for selecting, >> >> switching and running appropriate Device/Host mode. >> >> >> >> Signed-off-by: Pawel Laszc

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Pawel Laszczak
+ Tomek Klimek >> > + >> > +static inline void cdns3_role_stop(struct cdns3 *cdns) >> > +{ >> > + enum cdns3_roles role = cdns->role; >> > + >> > + if (role == CDNS3_ROLE_END) >> >> WARN_ON(role >= CNDS3_ROLE_END) ? >> >> > + return; >> > + >> > + mutex_lock(&cdns->mutex);

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Pawel Laszczak
Hi + Tomek >> > + * Cadence USBSS DRD Driver. >> > + * >> > + * Copyright (C) 2018 Cadence. >> > + * >> > + * Author: Peter Chen >> > + * Pawel Laszczak >> > + */ >> > + >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > + >> > +#include

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Peter Chen
On Wed, Dec 5, 2018 at 4:55 PM Alan Douglas wrote: > > Hi Peter, > > On 05 December 2018 07:20, Pawel Laszczak wrote: > > Hi, > > > > >> >> > > >> >> Patch adds core.c and core.h file that implements initialization > > >> >> of platform driver and adds function responsible for selecting, > > >> >>

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Peter Chen
> > > > On 04/12/18 10:50, Peter Chen wrote: > >>> + * Cadence USBSS DRD Driver. > >>> + * > >>> + * Copyright (C) 2018 Cadence. > >>> + * > >>> + * Author: Peter Chen > >>> + * Pawel Laszczak > >>> + */ > >>> + > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#i

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-05 Thread Alan Douglas
Hi Peter, On 05 December 2018 07:20, Pawel Laszczak wrote: > Hi, > > >> >> > >> >> Patch adds core.c and core.h file that implements initialization > >> >> of platform driver and adds function responsible for selecting, > >> >> switching and running appropriate Device/Host mode. > >> >> > >> >> S

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Pawel Laszczak
Hi, >> >> >> >> Patch adds core.c and core.h file that implements initialization >> >> of platform driver and adds function responsible for selecting, >> >> switching and running appropriate Device/Host mode. >> >> >> >> Signed-off-by: Pawel Laszczak >> >> --- >> >> drivers/usb/cdns3/Makefile |

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Roger Quadros
On 04/12/18 10:50, Peter Chen wrote: >>> + * Cadence USBSS DRD Driver. >>> + * >>> + * Copyright (C) 2018 Cadence. >>> + * >>> + * Author: Peter Chen >>> + * Pawel Laszczak >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Peter Chen
> Hi Roger > > >On 18/11/18 12:09, Pawel Laszczak wrote: > >> Patch adds core.c and core.h file that implements initialization > >> of platform driver and adds function responsible for selecting, > >> switching and running appropriate Device/Host mode. > >> > >> Signed-off-by: Pawel Laszczak > >>

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Peter Chen
> > + * Cadence USBSS DRD Driver. > > + * > > + * Copyright (C) 2018 Cadence. > > + * > > + * Author: Peter Chen > > + * Pawel Laszczak > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "gadget.h" > > +#include "co

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-03 Thread Peter Chen
On Mon, Dec 3, 2018 at 4:34 AM Pawel Laszczak wrote: > > >> > >> Patch adds core.c and core.h file that implements initialization > >> of platform driver and adds function responsible for selecting, > >> switching and running appropriate Device/Host mode. > >> > >> Signed-off-by: Pawel Laszczak >

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-02 Thread Pawel Laszczak
>> >> Patch adds core.c and core.h file that implements initialization >> of platform driver and adds function responsible for selecting, >> switching and running appropriate Device/Host mode. >> >> Signed-off-by: Pawel Laszczak >> --- >> drivers/usb/cdns3/Makefile | 2 + >> drivers/usb/cdns3/c

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-11-29 Thread Peter Chen
On Sun, Nov 18, 2018 at 6:16 PM Pawel Laszczak wrote: > > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-11-25 Thread Pawel Laszczak
Hi Roger >On 18/11/18 12:09, Pawel Laszczak wrote: >> Patch adds core.c and core.h file that implements initialization >> of platform driver and adds function responsible for selecting, >> switching and running appropriate Device/Host mode. >> >> Signed-off-by: Pawel Laszczak >> --- >> drivers/u

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-11-23 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile