RE: [PATCHv2 5/5] tools: ffs-test: add compatibility code for old kernels

2014-06-09 Thread Krzysztof Opasiak
ger.kernel.org > Subject: Re: [PATCHv2 5/5] tools: ffs-test: add compatibility code > for old kernels > > On Mon, Jun 09 2014, Krzysztof Opasiak wrote: > > As this is an example which will be copy-paste by many users > maybe you > > should you struct usb_functionfs_descs_head

Re: [PATCHv2 5/5] tools: ffs-test: add compatibility code for old kernels

2014-06-09 Thread Michal Nazarewicz
On Mon, Jun 09 2014, Krzysztof Opasiak wrote: > As this is an example which will be copy-paste by many users maybe you > should you struct usb_functionfs_descs_head and struct > usb_functionfs_descs_head_v2 instead of direct operations using > hard-coded offsets to make this function more readable?

RE: [PATCHv2 5/5] tools: ffs-test: add compatibility code for old kernels

2014-06-09 Thread Krzysztof Opasiak
Hi Michal, > -Original Message- > From: Michal Nazarewicz [mailto:min...@mina86.com] > Sent: Friday, June 06, 2014 11:13 AM > To: Felipe Balbi; Krzysztof Opasiak > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Michal > Nazarewicz > Subject: [PATCHv2 5/5] tools: ffs-test: add