Re: [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-20 Thread Roger Quadros
Hi Thomas, On 08/20/2013 06:04 PM, thomas.lan...@lantiq.com wrote: > Hello Roger, > > this will not work! > > Roger Quadros wrote on 2013-08-20: > >> -struct omap_control_usb_platform_data *pdata = >> -dev_get_platdata(&pdev->dev); >> + >> +if (np) { >> +

RE: [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-20 Thread thomas.langer
Hello Roger, this will not work! Roger Quadros wrote onĀ 2013-08-20: > - struct omap_control_usb_platform_data *pdata = > - dev_get_platdata(&pdev->dev); > + > + if (np) { > + of_property_read_u32(np, "ti,type", &control_usb->type); here you are dereferenc