Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-12 Thread Felipe Balbi
r...@lists.infradead.org; Greg Kroah-Hartman > > Subject: Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver > > > > On Monday 09 December 2013 09:54 PM, Balbi, Felipe wrote: > > > Hi, > > > > > > On Mon, Dec 09, 2013 at 05:17:04PM -0500,

RE: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-12 Thread Kwok, WingMan
> -Original Message- > From: Quadros, Roger > Sent: Monday, December 09, 2013 10:09 PM > To: Kwok, WingMan; linux-usb@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org; Shilimkar, Santosh; Balbi, Felipe; > Greg Kroah-Hartman > Subject: Re: [PATCH v3 2/2] u

RE: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-12 Thread Kwok, WingMan
> -Original Message- > From: Shilimkar, Santosh > Sent: Tuesday, December 10, 2013 10:15 AM > To: Balbi, Felipe > Cc: Kwok, WingMan; linux-usb@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; Greg Kroah-Hartman > Subject: Re: [PATCH v3 2/2] usb: phy: Add ke

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-10 Thread Santosh Shilimkar
On Monday 09 December 2013 11:47 PM, Felipe Balbi wrote: > Hi again, > > On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: >> +static int keystone_usbphy_init(struct usb_phy *phy) >> +{ >> +struct keystone_usbphy *k_phy = dev_get_drvdata(phy->dev); >> +u32 val; >> + >> +val

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-10 Thread Santosh Shilimkar
On Monday 09 December 2013 09:54 PM, Balbi, Felipe wrote: > Hi, > > On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: >> +ret = usb_add_phy_dev(&k_phy->usb_phy_gen.phy); >> +if (ret) >> +return ret; >> +k_phy->usb_phy_gen.phy.init = keystone_usbphy_init; >> +

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-09 Thread Felipe Balbi
Hi again, On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: > +static int keystone_usbphy_init(struct usb_phy *phy) > +{ > + struct keystone_usbphy *k_phy = dev_get_drvdata(phy->dev); > + u32 val; > + > + val = keystone_usbphy_readl(k_phy->phy_ctrl, USB_PHY_CTL_CLOCK); > +

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-09 Thread Roger Quadros
On 12/10/2013 03:47 AM, WingMan Kwok wrote: > Add Keystone platform USB PHY driver support. Current main purpose > of this driver is to enable the PHY reference clock gate on the > Keystone SoC. Otherwise it is a nop PHY. > > Cc: Santosh Shilimkar > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > A

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-09 Thread Felipe Balbi
Hi, On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: > + ret = usb_add_phy_dev(&k_phy->usb_phy_gen.phy); > + if (ret) > + return ret; > + k_phy->usb_phy_gen.phy.init = keystone_usbphy_init; > + k_phy->usb_phy_gen.phy.shutdown = keystone_usbphy_shutdown; th