Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-14 Thread Richard Zhao
On Fri, Sep 14, 2012 at 04:56:13PM +0800, Chen Peter-B29397 wrote: > > > diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c > > index c1a67cb..6a03e97 100644 > > --- a/drivers/usb/otg/mxs-phy.c > > +++ b/drivers/usb/otg/mxs-phy.c > > @@ -97,12 +97,24 @@ static int mxs_phy_on_disco

RE: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-14 Thread Chen Peter-B29397
> diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c > index c1a67cb..6a03e97 100644 > --- a/drivers/usb/otg/mxs-phy.c > +++ b/drivers/usb/otg/mxs-phy.c > @@ -97,12 +97,24 @@ static int mxs_phy_on_disconnect(struct usb_phy *phy, > int port) > return 0; > } > > +static int

Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-14 Thread Richard Zhao
On Wed, Sep 12, 2012 at 01:39:01PM +0300, Heikki Krogerus wrote: > Hi, > > On Tue, Aug 28, 2012 at 03:03:12PM +0800, Richard Zhao wrote: > > +static int mxs_phy_set_host(struct usb_otg *otg, struct usb_bus *host) > > +{ > > Shouldn't you at least save the host pointer? > > otg->host = host; It l

Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-12 Thread Heikki Krogerus
Hi, On Tue, Aug 28, 2012 at 03:03:12PM +0800, Richard Zhao wrote: > +static int mxs_phy_set_host(struct usb_otg *otg, struct usb_bus *host) > +{ Shouldn't you at least save the host pointer? otg->host = host; > + return 0; > +} > + > +static int mxs_phy_set_peripheral(struct usb_otg *otg, >

Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-11 Thread Felipe Balbi
Hi, On Tue, Aug 28, 2012 at 03:03:12PM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao if you add a commit log you can add my: Acked-by: Felipe Balbi > --- > drivers/usb/otg/mxs-phy.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/drivers/usb/otg/