Re: [PATCH v2] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers

2015-06-30 Thread Mathias Nyman
Hi On 30.06.2015 04:54, Reyad Attiyat wrote: > Hey Mathias, > > The intention is to send an extra endpoint packet of length zero as my > wireless card needs this to function properly. I have skimmed through > the xhci spec and assumed that each td would generate a packet. That > is why I do not c

Re: [PATCH v2] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers

2015-06-29 Thread Reyad Attiyat
Hey Mathias, The intention is to send an extra endpoint packet of length zero as my wireless card needs this to function properly. I have skimmed through the xhci spec and assumed that each td would generate a packet. That is why I do not chain the last trb or add a interrupt flag, since I don't w

Re: [PATCH v2] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers

2015-06-29 Thread Mathias Nyman
Hi On 29.06.2015 03:53, Reyad Attiyat wrote: > This commmit checks for the URB_ZERO_PACKET flag and creates an extra > zero-length td if the urb transfer length is a multiple of the endpoint's > max packet length. > > Signed-off-by: Reyad Attiyat > --- Thanks for the patch. Generic idea and imp

RE: [PATCH v2] usb: xhci: Add support for URB_ZERO_PACKET

2013-11-14 Thread David Laight
> From: Sarah Sharp > On Wed, Nov 13, 2013 at 12:28:09PM -, David Laight wrote: > > If URB_ZERO_PACKET is set on a transfer that is an integral number > > of maximum length packets (1k for USB3 bulk) then an additional > > zero length fragment must be sent. > > > > Merge together the functions

Re: [PATCH v2] usb: xhci: Add support for URB_ZERO_PACKET

2013-11-13 Thread Sarah Sharp
On Wed, Nov 13, 2013 at 12:28:09PM -, David Laight wrote: > If URB_ZERO_PACKET is set on a transfer that is an integral number > of maximum length packets (1k for USB3 bulk) then an additional > zero length fragment must be sent. > > Merge together the functions that setup single buffer and sc