Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 09:40:29AM +, Peter Chen wrote: > > > > > > > Required properties: > > > -- compatible: Should be "fsl,imx23-usbphy" > > > +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q- > > usbphy" > > > + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl > >

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Peter Chen
On Fri, Feb 21, 2014 at 10:46:41AM +0100, Marc Kleine-Budde wrote: > On 02/21/2014 10:40 AM, Peter Chen wrote: > > > >>> > >>> Required properties: > >>> -- compatible: Should be "fsl,imx23-usbphy" > >>> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q- > >> usbphy" > >>> + for

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Marc Kleine-Budde
On 02/21/2014 10:40 AM, Peter Chen wrote: > >>> >>> Required properties: >>> -- compatible: Should be "fsl,imx23-usbphy" >>> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q- >> usbphy" >>> + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl >> >> Minor nit, but could we re

RE: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Peter Chen
> > > > Required properties: > > -- compatible: Should be "fsl,imx23-usbphy" > > +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q- > usbphy" > > + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl > > Minor nit, but could we restructure this as something like the following

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 05:14:30AM +, Peter Chen wrote: > Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add > "fsl,imx6sl-usbphy" for imx6sl. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-)