Re: [PATCH 3/4 v2] staging: dwc2: add platform device bindings

2013-04-12 Thread Matthijs Kooijman
Hi Paul, > Also, at the top of dwc2_driver_probe() there is a call to > dwc2_set_all_params(), which is in a different module and thus won't > link. Ah, good point. I guess I should have added a EXPORT_SYMBOL_GPL(dwc2_set_all_params) as well when adding the declaration to hcd.h in the previous pat

RE: [PATCH 3/4 v2] staging: dwc2: add platform device bindings

2013-04-12 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Friday, April 12, 2013 2:33 PM > > On Fri, Apr 12, 2013 at 09:09:51PM +, Paul Zimmerman wrote: > > > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > > Sent: Friday, April 12, 2013 3:42 AM > > > > > > This adds a dwc_platform.k

Re: [PATCH 3/4 v2] staging: dwc2: add platform device bindings

2013-04-12 Thread Matthijs Kooijman
Hi Paul, On Fri, Apr 12, 2013 at 09:09:51PM +, Paul Zimmerman wrote: > > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > Sent: Friday, April 12, 2013 3:42 AM > > > > This adds a dwc_platform.ko module that can be loaded by using > > compatible = "snps,dwc2" in a device tree. > > > > S

RE: [PATCH 3/4 v2] staging: dwc2: add platform device bindings

2013-04-12 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Friday, April 12, 2013 3:42 AM > > This adds a dwc_platform.ko module that can be loaded by using > compatible = "snps,dwc2" in a device tree. > > Signed-off-by: Matthijs Kooijman > > --- > v2: remove useless debug prints > change