RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Ramneek Mehresh wrote: > > > This is the wrong way to connect platform-private data with the > > > ehci_hcd structure. The right way is to use an ehci_driver_overrides > > > structure, like in ehci-omap.c and quite a few other EHCI platform > > > drivers. > > > > > > Hi Alan

RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-20 Thread Ramneek Mehresh
; linux-usb@vger.kernel.org; > > ba...@ti.com; gre...@linuxfoundation.org > > Subject: Re: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb > > host driver > > > > On Tue, 7 Apr 2015, Ramneek Mehresh wrote: > > > > > Add workqueue to add/rem

RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-20 Thread Ramneek Mehresh
t: Re: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb > host driver > > On Tue, 7 Apr 2015, Ramneek Mehresh wrote: > > > Add workqueue to add/remove host driver (outside interrupt context) > > upon each id change > > This patch needs to be fixed. See below. >

Re: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-07 Thread Alan Stern
On Tue, 7 Apr 2015, Ramneek Mehresh wrote: > Add workqueue to add/remove host driver (outside interrupt context) > upon each id change This patch needs to be fixed. See below. > Signed-off-by: Ramneek Mehresh > --- > drivers/usb/host/ehci-fsl.c | 107 > ---