RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-25 Thread Andrzej Pietrasiewicz
Hi Felipe, On September 19, 2012 2:18 PM Felipe Balbi wrote: > > I wouldn't make functionN a directory. I think it's better to: > > echo "f_mass_storage" > /cfg/usb-function-gadget/ufg/config0/function0 I'd like to comment a little on your suggestion. In configfs there are config items, whic

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-19 Thread Alan Stern
On Wed, 19 Sep 2012, Andrzej Pietrasiewicz wrote: > I am wondering, if it is possible to use the same function more than > once in a given configuration? That is, if it is possible to have > > /cfg/usb-function-gadget/ufg/config1/function1/f_mass_storage > > and > > /cfg/usb-function-gadget/ufg

Re: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-19 Thread Felipe Balbi
On Tue, Sep 18, 2012 at 04:53:13PM +0200, Andrzej Pietrasiewicz wrote: > Hello Sebastian, > > On September 17, 2012 6:23 PM Sebastian Andrzej Siewior wrote: > > > > > > > Not looking at code. Can you give a few bash lines which setup the > > gadget? Please make it work with mass storage (which

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-19 Thread Andrzej Pietrasiewicz
On Tuesday, September 18, 2012 6:10 PM Alan Stern wrote: > > > > > $ mkdir /cfg/usb-function-gadget/ufg/config1/function1/\ > > > f_mass_storage > > Speaking of no purpose, what is the reason > for .../function1/f_mass_storage ? Is there anything besides name and > f_mass_storage under functi

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-18 Thread Alan Stern
On Tue, 18 Sep 2012, Michal Nazarewicz wrote: > On Tue, Sep 18 2012, Andrzej Pietrasiewicz wrote: > > This is how I would like to setup the gadget with mass storage > > (udc interface unchanged, so no udc choice for user; configfs root > > for the gadget is named "usb-function-gadget", probably to

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-18 Thread Michal Nazarewicz
On Tue, Sep 18 2012, Andrzej Pietrasiewicz wrote: > This is how I would like to setup the gadget with mass storage > (udc interface unchanged, so no udc choice for user; configfs root > for the gadget is named "usb-function-gadget", probably to be changed > after the udc-core supports choice of oth

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-18 Thread Andrzej Pietrasiewicz
Hello Sebastian, On September 17, 2012 6:23 PM Sebastian Andrzej Siewior wrote: > > Not looking at code. Can you give a few bash lines which setup the > gadget? Please make it work with mass storage (which is ported in 3/3) > and something else like serial or ncm (or $your_favorite) which > (o

Re: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-17 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-09-17 09:09:59 [+0200]: >Add USB functions gadget configured entirely through configfs. >This is the base for adding USB functions to it. The next patch >in the series demonstrates how to add functions. Not looking at code. Can you give a few bash lines which setup